Eclipse integration for kibit about kibit HOT 4 CLOSED

Hi @winks, thanks for this. cursive-ide/cursive#295 is wanting to do a similar thing in IntelliJ. Is there a common external tool format between Eclipse and IntelliJ that would make this reusable for both? (I know that's a tall ask) @cursiveclojure might have some thoughts on this too.

Regarding your patch:

• It would be more robust and concise to create the XML with an XML library rather than building strings by hand
• convert-to-path won't give the correct result for Clojure files that aren't in a src/ directory, or have a different extension to .clj
• Can you clean up the debugging statements?
• If there is no common format between IntelliJ and Eclipse then this should be a cinder-xml reporter
• I wonder whether this would be more suitable in it's own lein plugin. You could use all of the code from kibit as a library, but maintain your cinder reporter separately. My concern is that not enough people are using cinder to take it on as an additional reporter to support.

What are your thoughts?

from kibit.

Yay, an answer :)
Not duplicating effort is always welcome, but I haven't even used the stuff myself for years, plus in retrospect that code I wrote 2 years ago is pretty ugly (re your comments).

And you're definitely correct about using kibit as a library, but it's a bit of a chicken-egg-problem of discoverability, so I thought I'd help the eclipse users out there.

I'll think about this and keep an eye on that other bug.

from kibit.

Interesting approach. I'm hoping to provide something more integrated for Cursive, and unfortunately that means that the code is very hard to share. Cursive doesn't use standard Clojure forms, it uses internal types that mimic them since it has to extend IntelliJ base classes. I'd really like to do a proper integration in Cursive, because then you'll have all the warnings marked in the editor and be able to fix them on the fly with proper formatting and so on - that's really what you want. Additionally since Cursive can resolve symbols it can provide inspections that Kibit can't, for example:

(if-let [test (something)]
  ...)

can be turned into

(if (something)
  ...)

If test is never referred to.

from kibit.

I'll close this for now, I don't think IntelliJ and Eclipse will meet in the middle on this one. @winks if you do want to build a lein plugin I'd be happy to put a link to it in the kibit README like the emacs instructions. I don't think you'd lose discoverability if your eclipse-kibit plugin is documented on the kibit repo.

from kibit.