Giter Club home page Giter Club logo

Comments (2)

simone-silvestri avatar simone-silvestri commented on August 20, 2024

required_halo_size does not specialize for different directions.

function inflate_halo_size(Hx, Hy, Hz, grid, tendency_terms...)
topo = topology(grid)
for term in tendency_terms
H = required_halo_size(term)
Hx = inflate_halo_size_one_dimension(H, Hx, topo[1], grid)
Hy = inflate_halo_size_one_dimension(H, Hy, topo[2], grid)
Hz = inflate_halo_size_one_dimension(H, Hz, topo[3], grid)
end

i.e., the same error would appear also for horizontal closures that do not require halos in the vertical.
Would be good to add

required_halo_size_x
required_halo_size_y
required_halo_size_z

from oceananigans.jl.

glwagner avatar glwagner commented on August 20, 2024

Right, so this is a bug because the actual required halo size is 1, not 4.

from oceananigans.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.