Giter Club home page Giter Club logo

Comments (4)

glwagner avatar glwagner commented on June 16, 2024

If times is a Vector then it needs to be converted to arch_array and adapted when passed to GPU.

We're doing a big overhaul on #3450 and this is one of the thing we fixed:

if times isa AbstractArray
# Try to convert to a range, cuz
time_range = range(first(times), last(times), length=length(times))
if all(time_range .≈ times) # good enough for most
times = time_range
end
times = arch_array(architecture(grid), times)
end

from oceananigans.jl.

glwagner avatar glwagner commented on June 16, 2024

Basically we'd like to support range, vector, tuple. But range is preferred for sure, so we'll try to convert to one if we can. For irregularly spaced data we'll have to make a CuArray.

from oceananigans.jl.

jagoosw avatar jagoosw commented on June 16, 2024

Ah I see that makes sense. I didn't realise that PR was related sorry!

from oceananigans.jl.

glwagner avatar glwagner commented on June 16, 2024

No worries of course!

from oceananigans.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.