Obstacle too close to the area bound can lead to wrong path about open_mower_ros HOT 14 CLOSED

Visualization of the fix:

from open_mower_ros.

this fix is working for me

from open_mower_ros.

Thank you for the PR, while it fixes the issue you see it re-introduces an old one (which is the reason why the paths were merged in the first place).

The initial issue was that when not having the paths merged, there will be a piece of navigation between each outline (e.g. from the innermost to the next outer one). This will cause the mower to do the "rotate - drive - rotate" thing between each outline change. If we are close to an obstacle, the mower will crash in that case, because it is not round and therefore cannot necessarily rotate in place. This is especially true near obstacles. Since outlines are often near obstacles, it was a large issue - hence the grouping.

For a real fix, we need to group, but more intelligently (i.e. detect if the added path segment would lead through a forbidden area. In this case not group)

from open_mower_ros.

I have no idea of the source-code of Slic3r and I am more comfortable with graphical programming. It will be really hard for me to understand the code. But: For me it sounds like the problem is somewhere else, but not in the slic3r. Why is it rotating when it changes to navigation? In 3D printing it makes sense to distinguish between printing and moving, but here every move can be mowing. So maybe it is solved, if the navigation is redefined as mowing? Anyway I had examples with hand drawn rectangles, where at one path the mowing motor was switches off. There were only 3 straight lines mowing, and one line was not shown, but the mower drove it with slow mowing motor.

from open_mower_ros.

@karlranseierausrom since the mower cannot move sideways, on tight turns it needs to rotate on spot. It has nothing to do with mowing vs not mowing.

I.e. if you are driving the outline as a spiral, it will be one continuous motion, but if you do like two tight 90 degree turns between the lines, the mower will rotate in place, because it cannot just shift sideways like that. During polygon grouping, we can make sure that there are no such small 90 degree turns in there in order to avoid this behavior.

from open_mower_ros.

should be fixed in main, please test and report back. If anyone has map.bag files to test, feel free to share (e.g. discord or link here).

from open_mower_ros.

thank you @11phc for providing a very problematic map, here are some before and after pics

from open_mower_ros.

That is looking much better, thank you. So do you think you have fixed it now in the slicer / router planner?
Or are my maps a bit "corrupted" from the start (because of my alternative way of creating them in arcgis and exporting to GPX etc.) and you did it instead by modifying my maps?

from open_mower_ros.

Code changes only, I did not touch the maps

from open_mower_ros.

@karlranseierausrom since the mower cannot move sideways, on tight turns it needs to rotate on spot. It has nothing to do with mowing vs not mowing.

Looks like I didn't understand the problem. I observed some weird 270° and -270° moves at some point. I thought you were talking abut the

Is a json file useful, too? Do you want another? I deleted the area and will rewrite it on the weekend and test the new version. Than I can stay on official edge and don't need my extra repo.

Thanks for all your work!

from open_mower_ros.

currently in edge version (I have just completely redone the SD card)

my mower always tries to cross my obstacles I attach a screenshot of the GUI interface

I share with you by map.bag on ([email protected])

thank you for your work on this project

from open_mower_ros.

This looks like an edited map with sparse points which is known to break the path planning algorithm

from open_mower_ros.

I drew the map from the gui interface (https://github.com/cedbossneo/openmower-gui)
the problem and maybe due to that?

Is there a way to modify the map and correct this?

from open_mower_ros.

Yes, the edited maps are known to cause issues. I did not look into the map editors too much, so I can't really help with this. Best would be to just record the map instead of creating it in the UI. If you have questions regarding map editing, you can try asking on Discord or in the GUI repo, I know that some people do it successfully.

I'm closing this for now, since it is reported fixed by some people.

from open_mower_ros.