Images with a `*.JPG` extension are missed about cleanvision HOT 5 CLOSED

in this case, if we just include the extension ".JPG" in the constants then glob should be able to find these files. No?

from cleanvision.

@stefanistrate Thanks for reporting this issue! Agree CleanVision should work across the supported file extensions regardless of their letter case. There was previously some trickiness to ensuring proper behavior across Windows + other OS.

Got any specific code fixes you suggest? PRs are always welcome 😄

And for your use-case, I believe you should still be able to run Imagelab with the filepaths argument instead?

from cleanvision.

filepaths could work in my case, although if I have nested directories it becomes the same problem of listing all image files efficiently. What I could recommend instead, in terms of implementation, is to call glob.glob() just once to list all files, then split the extension from each of them and finally match its lowercase version against a set of allowed extensions. This would also have the advantage of not needing to de-duplicate items on Windows.

from cleanvision.

Yes, that's correct.

from cleanvision.

should be closed by: #200
Feel free to re-open the issue if you still have problems with developer versions of cleanvision or after next stable release

from cleanvision.