NewSignature error about obfuscapk HOT 10 CLOSED

Hi @esauvisky, there is no particular reason for having an hardcoded keystore (maybe just to keep the configuration minimal for who is using the tool). We hardcoded it when we started the development since the keystore parameters were always the same, but actually it's a good idea to make this configurable via CLI: I think we should add --keystore-file, --keystore-password and --key-alias optional parameters (and fallback to the default keystore if none of these parameters are provided).

from obfuscapk.

Have you used the correct password and key alias? Currently this information is hard-coded in the following code, so if you change the keystore you have to also change the password and the key alias.

from obfuscapk.

Looks like it needs a way to pass a new password;
How can I do that?

from obfuscapk.

I see the part you refer to;
so Which one is the passwd and the alias?

os.path.dirname(file), "resources", "obfuscation_keystore.jks"
),
"obfuscation_password",
"obfuscation_key",

from obfuscapk.

Looking at this https://docs.oracle.com/javase/tutorial/deployment/jar/signing.html
and this
https://docs.oracle.com/javase/7/docs/technotes/tools/windows/jarsigner.html#CCHFIDAB
I am having trouble reconciling with your syntax:
their examples only have Alias parameter after the .apk file; yours obviously differs
Please explain.

from obfuscapk.

Here is the final code that is executed to sign the application (the above code is only a helper method):

from obfuscapk.

Seems to be working now, thanks!

from obfuscapk.

Sorry for bumping a closed issue, but is there any particular reason for the signing to be hardcoded? For me it'd make more sense if you could specify your own keystore, pass and alias from the CLI for example 🤔

from obfuscapk.

from obfuscapk.

I think we should add --keystore-file, --keystore-password and --key-alias optional parameters (and fallback to the default keystore if none of these parameters are provided).

Implemented with latest commit 7860fc1.

from obfuscapk.