Item.set doesn't work as advertised about dynogels HOT 3 OPEN

Changing from merge to extend would probably be backwards-incompatible change and potentially even dangerous if there are existing users that depend on merging strategy right now, no? It should probably be configurable either from the set call or globally but default to current behavior.

from dynogels.

That's a legitimate worry. However, the current behavior is a bug. So perhaps there's a path to fixing this:

1. Add a property mergeWhenSettingObjectAttributes to the dynogels top level which sets an internal property
2. Add a conditional warning:
   • if this value is undefined, and use the default _.merge behavior:

   "Warning: Please explicitly set mergeWhenSettingObjectAttributes. see https:\\github.com\clarkie\dynogels\issues\174 for details. Current default behavior of Item.set, when value is an object, is to merge the new object with the existing object. In a future major release, this will change to overwrite. Use dynogels.mergeWhenSettingsObjectAttributes=false for overwrite behavior. Set to true for merge behavior."

   • else If value is set to falsey, use _.extend,
   • else value is truthy, so use _.merge.
3. On next major version bump, switch the behavior to _.extend.

from dynogels.

Unexpected as it is, it seems like the behaviour is by design, because Item.prototype.update uses Item.prototype.set

from dynogels.