When BRANCH is a tag --incremental does not work about tc-build HOT 6 CLOSED

Yes, we run git fetch origin which will fetch both new tags and branches. It looks like your example properly checked out. llvmorg-9.0.0-rc1?

from tc-build.

Does not work how? What do you expect it to do?

from tc-build.

I checkout release/9.x Git branch and then tried a week later to checkout llvmorg-9.0.0-rc1 Git tag by doing an incremental pull-ing.
Unsure if this is smart/allowed/foreseen-in-the-design.

Are remote Git tags fetched when using -B/--branch option?

from tc-build.

The Git tag was indeed recognized/fetched.

$ git branch
* (HEAD detached at llvmorg-9.0.0-rc1)
  release/9.x

Manually I did:

$ cd tc-build/llvm-project

$ git ls-remote --tags origin | grep '9.0.0-rc1'
f85f31d608a7248e2fd419dee11371dcb9bd1efd        refs/tags/llvmorg-9.0.0-rc1
6aa75a25bdeea9cdc4b04cdd91e82e680444bf4b        refs/tags/llvmorg-9.0.0-rc1^{}

$ git checkout -b llvmorg-9.0.0-rc1 tags/llvmorg-9.0.0-rc1

In terms of a Git branch I expected to have exactly what the last line does: a local branch called llvmorg-9.0.0-rc1 not (HEAD detached at llvmorg-9.0.0-rc1).
Maybe this is just a cosmetical thing.

BTW, above I see two Git tags.
The commit-id 6aa75a25bdeea9cdc4b04cdd91e82e680444bf4b is the commit-id of the llvmorg-9.0.0-rc1 Git tag. What is the difference?

from tc-build.

In terms of a Git branch I expected to have exactly what the last line does: a local branch called llvmorg-9.0.0-rc1 not (HEAD detached at llvmorg-9.0.0-rc1).
Maybe this is just a cosmetical thing.

The script runs git checkout, rather than git checkout -b. So by specifying llvmorg-9.0.0-rc1 as the "branch", git checkout will put you into a detached HEAD state. If you want a branch instead, you should just manage the repository yourself and pass in --no-update to the script.

BTW, above I see two Git tags.
The commit-id 6aa75a25bdeea9cdc4b04cdd91e82e680444bf4b is the commit-id of the llvmorg-9.0.0-rc1 Git tag. What is the difference?

f85f31d608a7248e2fd419dee11371dcb9bd1efd is the tag object, 6aa75a25bdeea9cdc4b04cdd91e82e680444bf4b is the commit that the tag points to.

from tc-build.

Re-reading this, I think there is some confusion over the meaning of --incremental. --incremental deals with not removing the build artifacts from a previous compile, not incrementally updating the repo. There is no bug here.

from tc-build.