Giter Club home page Giter Club logo

Comments (10)

clade avatar clade commented on September 4, 2024

Thank you for pointing out this bug. On need to add the unit to the sting send to the instrument.
I think it is now corrected on commit ce651cd (dev branch)

I don't have a powermeter on hand to test. Could you test it ?

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

I tested it but the problem is still there.

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

The beamdiameter also won't change but changing the average count works fine for me.

from thorlabspm100.

clade avatar clade commented on September 4, 2024

I initially tought that Thorlabs requires the unit when the command is send.
I manage to do some test on a PM100A. The wavelength is not changed when the required wavelength in not in the range of the sensor.

The commit d77ad7d add an automatic test for the wavelength. It works on my device.

Now the command :
power_meter.sense.correction.wavelength = 780
works. But the command :
power_meter.sense.correction.wavelength = 10
raises an Exception.

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

I am testing it on the PM101. The commands in the manual are the same on first sight. I have a sensor with wavelength range of 800-1700 nm but power_meter.sense.correction.wavelength = 1310 f.e. doesn't work.

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

OK on the Thorlabs PM100D everything works fine. The only thing that is not clear for me is how to change the configuration from CURR to POW.

from thorlabspm100.

clade avatar clade commented on September 4, 2024

This is a different question. I think that :
powermeter.configure.scalar.current.dc()
powermeter.configure.scalar.power()
will change the setting of powermeter.read

from thorlabspm100.

clade avatar clade commented on September 4, 2024

I am testing it on the PM101. The commands in the manual are the same on first sight. I have a sensor with wavelength range of 800-1700 nm but power_meter.sense.correction.wavelength = 1310 f.e. doesn't work.

According to the datasheet, it should work with the PM101.
What is the result of power_meter.sense.correction.minimum_wavelength

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

The result is 800. I already contacted the Thorlabs tech support. Let's see what they say about it.

from thorlabspm100.

peakflyer avatar peakflyer commented on September 4, 2024

I now figured out what caused the problem. In the wavelength class it says:
value = Argument(0, ["MINimum", "MAXimum", "<numeric_value>nm"])
The unit has to be removed as in the following line:
value = Argument(0, ["MINimum", "MAXimum", "<numeric_value>"])

Interestingly on the PM100D its working perfectly fine with and without the unit whereas on the PM101 it only works without the unit. Therefore I think the unit should be removed on every setter command. That is also what the Throlabs technical support told me.

from thorlabspm100.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.