Giter Club home page Giter Club logo

Comments (9)

ckirkendall avatar ckirkendall commented on July 28, 2024

Not sure you can use meta like this with a macro but a map instead of key word for options I think is a brilliant idea. It gives us a syntax that is expandable without having to change the basic structure.

from enfocus.

superbobry avatar superbobry commented on July 28, 2024

Turns out you actually can use metadata in macros calls:

user=> (defmacro deftemplate [name & _] (pr-str (meta name)))
#'user/deftemplate
user=> (macroexpand-1 '(deftemplate ^:private foo))
"{:private true}"

from enfocus.

ckirkendall avatar ckirkendall commented on July 28, 2024

Were you doing this in a clojurescript repl? If not can you try it in a clojurescript repl. Not all the information you normally get in clojure is passed by the clojurescript compiler during macro expansion. If we can do this that would be great. If the clojurescript repl does not work, I can work on adding to the clojurescript compiler. I already have to add sending the namespace of symbols.

from enfocus.

superbobry avatar superbobry commented on July 28, 2024

Nope, that was a Clojure repl, here's a ClojureScript example:

;; macros.clj
(defmacro deftemplate [name & _]
  `(.log js/console (pr-str ~(meta name))))

;; test.cljs
(deftemplate ^:private foo)

When I try this, I see {:private true} in the browser console, so I guess it's possible in the ClojureScript as well.

from enfocus.

ckirkendall avatar ckirkendall commented on July 28, 2024

That is great, I like this a lot better than the :compile :remote setup we
had.

CK

On Thu, Jun 7, 2012 at 4:39 PM, Sergei Lebedev <
[email protected]

wrote:

Nope, that was a Clojure repl, here's a ClojureScript example:

;; macros.clj
(defmacro deftemplate [name & _]
  `(.log js/console (pr-str ~(meta name))))

;; test.cljs
(deftemplate ^:private foo)

When I try this, I see {:private true} in the browser console, so I
guess it's possible in the ClojureScript as well.


Reply to this email directly or view it on GitHub:
#13 (comment)

from enfocus.

ckirkendall avatar ckirkendall commented on July 28, 2024

The more I think about this the more I love it! Its clean, doesn't affect the syntax of the macro and can be extended easily. If I get some time this weekend I will take a crack at this, unless you are already implementing something.

from enfocus.

superbobry avatar superbobry commented on July 28, 2024

One more thing we need to decide on: do we allow passing metadata to the generated functions, or is it enfocus-only? :private is a good example of this.

from enfocus.

superbobry avatar superbobry commented on July 28, 2024

I've created a feature/metadata branch in my fork.

from enfocus.

ckirkendall avatar ckirkendall commented on July 28, 2024

@superbobry I noticed in your branch you have the location as part of the meta data. I would like to keep the syntax as consistent as possible. The location is a required part and should remain as part of the normal syntax where as private and compiled are optional inputs best left in the meta data. What you got so far looks great, I am thinking about moving towards 1.0 release and would love to have this be part the first release. I have finished up quite a bit of the Domina migration and If you want to concentrate on this I can take a look at the event stuff. Thanks again for helping out with Enfocus it is very appreciated!

CK

from enfocus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.