Rename the Core module to CKB module about ckb-sdk-js HOT 3 CLOSED

#407

from ckb-sdk-js.

I'd be great if this keeps some certain of back compatibility. For example, if the module is renamed to ckb, could we have an alias (or example) to map core to ckb so existing codebase using JavaScript SDK could just update one line to upgrade?

from ckb-sdk-js.

I'd be great if this keeps some certain of back compatibility. For example, if the module is renamed to ckb, could we have an alias (or example) to map core to ckb so existing codebase using JavaScript SDK could just update one line to upgrade?

In fact, the name Core is defined by user in the following ways:

import Core from '@nervosnetwork/ckb-sdk-core'
const { default: Core } = require('@nervosnetwork/ckb-sdk-core')
const Core = require('@nervosnetwork/ckb-sdk-core').default

They can use any name they like:

import CKB from '@nervosnetwork/ckb-sdk-core'
const { default: CKB } = require('@nervosnetwork/ckb-sdk-core')
const CKB = require('@nervosnetwork/ckb-sdk-core').default

This issue only reminds me of renaming the class name from Core to CKB, while it's the default export, this update doesn't have any effects on usage.

from ckb-sdk-js.