308 PERMANENT REDIRECT does not use ckan_site_url about ckan HOT 11 CLOSED

@kowh-ai if you have time are you able to reproduce this?

from ckan.

It seems to be related to the fact that while site_url seems to be the defining standard by which things get redirected, in this code block it seems to be treating that config as a bystander and using other native flask and environment properties to redirect. Followed to this point from the 308 redirect.

from ckan.

401 Forbidden seems to have the same issue, as discovered in ckan/ckanext-harvest#522.

from ckan.

Hello @FuhuXia I've tested this against master and 2.10.4 but can't reproduce the issue. Is there any more information you could provide?

from ckan.

Thanks @wardi for addressing this. I built a fresh Ubuntu 22 on a Virtualbox, have docker engine installed, following the exact steps in the description, I can replicate this bug.

from ckan.

@FuhuXia you've reported this against 2.10, did you try with 2.10.4?

from ckan.

Yes, I meant 2.10.4, since https://github.com/ckan/ckan-docker master branch is using 2.10.4
https://github.com/ckan/ckan-docker/blob/cc095f1323a6dc81d49ae76c5c24bc1d9a1c0172/ckan/Dockerfile#L1

from ckan.

Thanks, @FuhuXia and @jbrown-xentity I can reproduce this with https://github.com/ckan/ckan-docker but not in my normal development environment, so you're probably right about it being sensitive to the environment.

from ckan.

It looks like this issue was fixed here on master: 8787542 but not backported to release versions. @FuhuXia would you confirm that this fixes the issue you're seeing and we'll get this backported to 2.10.5

from ckan.

@wardi
Confirmed. 8787542 fixed this issue.

from ckan.

Great, thanks @FuhuXia I've marked it for backporting

from ckan.