Python libsvm 3.33 crashes due to unexpected argument to jit about libsvm HOT 9 OPEN

@advilbn Yes, I am aware functools.wraps forwards function attributes such as name and docstrings. As mentioned, jit being the identity doesn't suffer from those problems, there isn't a wrapper to begin with. For example

def jit(func=None, *args, **kwargs):
    if func is None:
        return lambda x: x
    else:
        return func

@jit
def f():
    """docstring f"""

@jit(nopython=True)
def g():
    """docstring g"""

print(f.__name__) # f
print(f.__doc__) # docstring f
print(g.__name__) # g
print(g.__doc__) # docstring g

If there are no other concerns, we will proceed as planned.

from libsvm.

@advilbn I am not a maintainer of this project, but I agree it should be yanked. As it stands, just importing the python code without numba installed breaks.

Regarding the suggested code, I agree it looks better this way and will update it.

from libsvm.

@advilbn Version 3.33.0 has been yanked from PyPI, thanks for the reminder.

from libsvm.

You could also yank the current version 3.33.0 in pypi, that way no one would need to pin/exclude manually this version.

@nilfm99 , in your PR (#219), you could use a version of the decorator using, functools.wrapps

try:
    from numba import jit
    jit_enabled = True
except:
    from functools import wraps as functools_wraps
 
    def jit(_func=None, *args, **kwargs):
        def decorator_jit(func):
            @functools_wraps(func)
            def wrapper_jit(*args, **kwargs):
                return func(*args, **kwargs)
            return wrapper_jit

        return decorator_jit if _func is None else decorator_jit(_func)
 
    jit_enabled = False

from libsvm.

from libsvm.

@cjlin1 , Could you also yanked the version 3.33.0 ? As i mentioned before this prevents users or automatic cicd pipelines to fail installing this version. Yanking gives time to not rush patching but providing a good user event/issue experience.

NoteL You could yank the package in the pypi website using you account.

Thank in advances, for all you help on this.

from libsvm.

@nilfm99 We are in the process of releasing 3.33.1, and we opted to use the original commit 8802a10 in your PR. functools.wraps seems to be more complicated than necessary for our purpose because jit is never going to be anything other than identity, which doesn't have issues with function attributes. Are there other concerns I missed?

from libsvm.

@Sinacam , please check functools.wraps documentations, https://docs.python.org/3/library/functools.html#functools.wraps. Using it is more a technicality to avoid loosing the name and docstrings when using decorators. the documentation has an example, that illustrates it.

from libsvm.

@Sinacam , thanks for the explanation and your help on this. No concerns from my end.

from libsvm.