Comments (4)
Thanks for the PR, I've merged it. Could you run over the code and maybe fix PSR-4 standards for the rest of it?
For example, what happens if you run the ./examples/nep5-functions.php? When i get the package from packagist, i get errors on the neoassets:
PHP Fatal error: Class 'NeoPHP\NeoAssets' not found in /Users/benjamindebos/Dropbox/LocalDevelopment/test123456/neo-php/examples/nep5-functions.php on line 13
Fatal error: Class 'NeoPHP\NeoAssets' not found in /Users/benjamindebos/Dropbox/LocalDevelopment/test123456/neo-php/examples/nep5-functions.php on line 13
Let me know!
from neo-php.
Hi, thanks for merging the PR !
I will have a look at the above, and any other composer issues. If it's okay for you, I could run PHP-Codestyle-Fixer on this project, to ensure it's adhering to PSR-2 codestyle. (would be a big commit though, mainly codestyle changes!)
I also noticed there are a few docblocks stating return type: void
, while the function returns something. FYI, these (minor) issues are all reported to me by PHPStorm, because I'm using PHP inspections. It's worth trying, if you're already using PHPStorm.
from neo-php.
That would be awesome! Please do everything that's within your capabilities to make this project even more pretty and better than before :)
from neo-php.
Okay, going to do this now !
from neo-php.
Related Issues (13)
- Can I use this wallet to transfer neo coin from one address to another HOT 3
- Please help...."sendtoaddress" RPC method
- How convert ByteArray string to NEO address?
- Use versions instead of dev-master HOT 4
- Implement methods to work with cli api
- Class not found NEOPHP\Crypto\gmp_Utils HOT 1
- bcrand() not working HOT 2
- About vin attribute in getRawTransaction
- Hardcoded list of assets HOT 2
- Help. transactions. HOT 3
- Getting an incorrect wallet balance for some tokens HOT 2
- not running in php HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neo-php.