Giter Club home page Giter Club logo

Comments (4)

Woodehh avatar Woodehh commented on June 29, 2024

Thanks for the PR, I've merged it. Could you run over the code and maybe fix PSR-4 standards for the rest of it?

For example, what happens if you run the ./examples/nep5-functions.php? When i get the package from packagist, i get errors on the neoassets:

PHP Fatal error:  Class 'NeoPHP\NeoAssets' not found in /Users/benjamindebos/Dropbox/LocalDevelopment/test123456/neo-php/examples/nep5-functions.php on line 13

Fatal error: Class 'NeoPHP\NeoAssets' not found in /Users/benjamindebos/Dropbox/LocalDevelopment/test123456/neo-php/examples/nep5-functions.php on line 13

Let me know!

from neo-php.

pepijnolivier avatar pepijnolivier commented on June 29, 2024

Hi, thanks for merging the PR !

I will have a look at the above, and any other composer issues. If it's okay for you, I could run PHP-Codestyle-Fixer on this project, to ensure it's adhering to PSR-2 codestyle. (would be a big commit though, mainly codestyle changes!)

I also noticed there are a few docblocks stating return type: void, while the function returns something. FYI, these (minor) issues are all reported to me by PHPStorm, because I'm using PHP inspections. It's worth trying, if you're already using PHPStorm.

from neo-php.

Woodehh avatar Woodehh commented on June 29, 2024

That would be awesome! Please do everything that's within your capabilities to make this project even more pretty and better than before :)

from neo-php.

pepijnolivier avatar pepijnolivier commented on June 29, 2024

Okay, going to do this now !

from neo-php.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.