Comments (5)
I think the right place to fix this is in the collectContentImage
hook: If lineAttributes.img
is a URL that does not match the expected form then upload the image (like the toolbar button does) and use the resulting URL instead. One problem with this approach: Like many client-side hooks, the collectContentImage
hook is executed synchronously. We need to change Etherpad core to execute it asynchronously.
from ep_image_upload.
Is there any way to disable CTRL+V until this issue is resolved? Pasting images is the only way that my team is inserting images at this point, but disabling the feature and forcing them to upload an image file would help them avoid shooting themselves in the foot.
from ep_image_upload.
Another problem: Pasting does not respect the maxFileSize limitation, so it's possible to insert arbitrary long images, regardless of the limit. (Only limited by Socket.io's max http buffer setting)
from ep_image_upload.
@webzwo0i yikes.
from ep_image_upload.
#56 tries to solve this. Any feedback welcome
from ep_image_upload.
Related Issues (20)
- ep_ copy_ paste_ Images and ep_ image_ upload cannot coexist HOT 1
- publish to npm? HOT 1
- image import through the API HOT 2
- Does S3 bucket credentials are exposed while uploading ? HOT 1
- toolbar icon should not be visible in read-only mode HOT 1
- TypeError of class constructor URL HOT 4
- Preview URL pasted image which was not uploaded HOT 1
- Invalid URL TypeError HOT 8
- Line numbering is broken -- Testing in Azure HOT 6
- Failed to load modules HOT 2
- images uploaded with ep_copy_paste_images are not displayed HOT 2
- BUG: Support to configure upload image button (addImage) in toolbar has been lost
- local storage in docker HOT 1
- Deleting locally stored images
- Images do not get exported to pdf or word
- Can't install the plugin on etherpad-lite-win-1.8.14 HOT 1
- BUG: Error messages not looking like errors.
- upgrade from ep_copy_paste_images fails
- migrating from ep_copy_images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ep_image_upload.