Giter Club home page Giter Club logo

Comments (5)

rhansen avatar rhansen commented on August 20, 2024

I think the right place to fix this is in the collectContentImage hook: If lineAttributes.img is a URL that does not match the expected form then upload the image (like the toolbar button does) and use the resulting URL instead. One problem with this approach: Like many client-side hooks, the collectContentImage hook is executed synchronously. We need to change Etherpad core to execute it asynchronously.

from ep_image_upload.

alexeisenhart avatar alexeisenhart commented on August 20, 2024

Is there any way to disable CTRL+V until this issue is resolved? Pasting images is the only way that my team is inserting images at this point, but disabling the feature and forcing them to upload an image file would help them avoid shooting themselves in the foot.

from ep_image_upload.

webzwo0i avatar webzwo0i commented on August 20, 2024

Another problem: Pasting does not respect the maxFileSize limitation, so it's possible to insert arbitrary long images, regardless of the limit. (Only limited by Socket.io's max http buffer setting)

from ep_image_upload.

JohnMcLear avatar JohnMcLear commented on August 20, 2024

@webzwo0i yikes.

from ep_image_upload.

webzwo0i avatar webzwo0i commented on August 20, 2024

#56 tries to solve this. Any feedback welcome

from ep_image_upload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.