Giter Club home page Giter Club logo

Comments (4)

Vela-zz avatar Vela-zz commented on June 27, 2024

hello, kenny, I may have time add a small update for this

but I have few questions

  1. what should default install command pip install langcheck do, would it only install support for default language, like [en] e.g. or let it install supoprt for all language? install former way seem easier to realized.
  2. if split like this
dev = [
    "yapf==0.40.1",
    "flake8",
    "isort",
    "pyright",
    "pandas-stubs",
    "pytest",
    "sphinx",
    "sphinx-book-theme",
    "myst-parser",
    "ipykernel"
]
zh = [
    'hanlp >= 2.1.0b33',
]
ja = [
    'fugashi',  # For tokenizer of metrics.ja.toxicity()
    'janome >= 0.3.1',
]

the github action file may also need a small update like, pip install -e .[dev,zh,ja], e.g.

what's your opinion ?

from langcheck.

kennysong avatar kennysong commented on June 27, 2024

Hi @Vela-zz, that would be fantastic!

  • what should default install command pip install langcheck do, would it only install support for default language, like [en] e.g. or let it install supoprt for all language? install former way seem easier to realized.

I think we can make pip install langcheck install a default language (English) to improve the default installation process.

the github action file may also need a small update like, pip install -e .[dev,zh,ja], e.g.

Agreed, we'll need to update all GH Actions, including the new Pip Install Matrix (we might want to add a third matrix dimension for "language").

dev = [
    "yapf==0.40.1",
    "flake8",
    "isort",
    "pyright",
    "pandas-stubs",
    "pytest",
    "sphinx",
    "sphinx-book-theme",
    "myst-parser",
    "ipykernel"
]
zh = [
    'hanlp >= 2.1.0b33',
]
ja = [
    'fugashi',  # For tokenizer of metrics.ja.toxicity()
    'janome >= 0.3.1',
]

@liwii do you know which dependencies in pyproject.toml are Japanese-only?

@ischender do you know which dependencies in pyproject.toml are German-only? (if any?)


I'm happy to help you with parts of this PR, e.g. I can update GitHub Actions, if you want.

from langcheck.

kennysong avatar kennysong commented on June 27, 2024

Also, not sure if this is possible, but it might be nice to have pip install langcheck[all] which installs all languages without dev dependencies.

from langcheck.

ischender avatar ischender commented on June 27, 2024

That would be neat!
@kennysong , I am pretty sure the only German only part is that we download the translation model from Huggingface, but that happens when it's run the first time.

from langcheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.