Comments (9)
@LeeLammert Could you please add some extra information? I can't reproduce your issue with that image using either "dockerImage"
or "dockerRunning"
. The following should help diagnose the issue:
- The check that you're running (JSON).
- The output of distributive running that test with
-v=2
flag set. - The commands you used to start the docker container/download the image.
Thank you!
from distributive.
Adding docker.io/
to a container image path is a RedHat thing. http://rhelblog.redhat.com/2015/04/15/understanding-the-changes-to-docker-search-and-docker-pull-in-red-hat-enterprise-linux-7-1/
from distributive.
On Thu, 18 Jun 2015, Langston Barrett wrote:
@LeeLammert Could you please add some extra information? I can't reproduce your issue with that image using either
"dockerImage"
or"dockerRunning"
. The following should help diagnose the issue:
- The check that you're running (JSON).
- The output of distributive running that test with
-v=2
flag set.- The commands you used to start the docker container/download the image.
-bash-4.2# cat docker.json
{
"Name": "Docker checks (requires root permissions)",
"Checklist" : [
{
"Check" : "dockerImage",
"Parameters" : ["docker.io/ciscocloud/mesos-consul"]
},
{
"Check" : "dockerRunning",
"Parameters" : ["docker.io/ciscocloud/mesos-consul"]
}
]
}
The problem seems to be that distributive is prefixing the image name with
"docker.io", whereas a "docker ps" does not show the "docker.io" prefix.
Lee
from distributive.
More info - it appears that "docker image" and "docker running" require different name specs:
{
"Name": "Docker checks (requires root permissions)",
"Checklist" : [
{
"Check" : "dockerImage",
"Parameters" : ["docker.io/ciscocloud/mesos-consul"]
},
{
"Check" : "dockerRunning",
"Parameters" : ["ciscocloud/mesos-consul:v0.1.1"]
}
]
}
These pass.
from distributive.
@LeeLammert Thanks! Does docker ps -a
include the "docker.io" prefix?
from distributive.
docker ps does not show the docker.io prefix, .. it is required for "dockerImage", but NOT for "dockerRunning:; in addition, "dockerRunning" requires a version, but "dockerImage" does not.
from distributive.
@LeeLammert I am wondering specifically if there is a difference between docker ps
and docker ps -a
, because Distributive uses the output from docker ps -a
.
from distributive.
We could add a note to the role check file with example names, .. but the version requirement on dockerRunning troubles me - it would have to be adjusted every time an image version bumps.
from distributive.
@LeeLammert I think you're right. The version can easily be made optional. I'll implement that.
from distributive.
Related Issues (20)
- Sample checklists should all work in Docker HOT 3
- Merge distributive and goss HOT 15
- Check for ulimit for root user HOT 2
- Add support for inode checks
- inodeUsageByMountpoint HOT 1
- UserInGroup errors when validating groups. HOT 7
- UserInGroup errors when validating groups. HOT 1
- 'Port' check does not check for ipv6 ports HOT 4
- DockerRunning and DockerRunningRegexp fail on containers without ports HOT 1
- Unit tests failing
- "real" releases
- Release 0.2.5 rpm name HOT 1
- Switch to glide/vendoring
- Check connection latency HOT 1
- Crash when using TCPTimeout
- Use YAML for configuration
- build release binaries in CI
- Docker daemon latency
- Unable to find the file size. HOT 2
- This project has moved to Mantl
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from distributive.