Comments (3)
I figured it could use some changes, yes - I was in a hurry to "just get it working" for my own purposes 😅. (This is exactly why I only opened an issue with the information and didn't open a PR instead; to give you guys the room to solve this more cleanly than I did.)
And yeah, I'd expect a double include like that to have some sort of guards around it... my guess it might not be getting caught because it's two different paths for the same file and the compiler isn't detecting they are the same. I'll take a look at this soon-ish and will report to Cygwin as well if it looks like that makes sense. 👍
from libsrtp.
No opinion on the correctness of the patch, but this could probably use a comment.
If they're the same file I would expect the headers to make sure double-includes work fine already tbh, perhaps this should be reported to the Cygwin folks as well?
from libsrtp.
@Thulinma I agree with @tp-m , it should be fine to include both, are there no include guards in place?
It should be noted that in the main branch integers.h has been removed, but maybe this problem has just moved to a different file now, would need to test.
Regards integers.h is in the latest release so it would be good to address this.
If the windows builds where enabled in .github/workflows/meson.yml then it should have help catch this earlier.
Thanks for reporting it and we will see what we do with it, the patch seams a bit hackish but it is a start.
from libsrtp.
Related Issues (20)
- Performance issue with OpennSSL 3 and libsrtp HOT 9
- Build fails on macOS -Wshorten-64-to-32 HOT 2
- How to compile libsrtp2.3.0 with AES-GCM cipher group support ? HOT 1
- Cross-compile libsrtp to Windows (64-bit) is failing given that OpenSSL can't be found HOT 1
- When is safe to use srtp_remove_stream? HOT 2
- Bad link in README.md HOT 1
- Release Version 3.0.0 HOT 3
- Use consistent types through out code base HOT 1
- Review public API
- libsrtp + openssl + certificates HOT 2
- remove NO_64BIT_MATH code
- update config options for crypto backend
- ABI break in 2.6.0 HOT 2
- meson ci build failing with mbedtls on macos HOT 2
- meson ci builds failing for openssl on macos HOT 4
- Return codes when calling unprotect HOT 7
- Failure to update key after mki failure HOT 3
- consider merging the gcm encrypt and get tag functions of cipher api
- Authentication error return by srtp_unprotect for AES CM 256 HMAC SHA1 80 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsrtp.