Keep review approvals about rebase HOT 8 OPEN

I'm not sure if actions have enough permissions to reinstate the approvals from other users. 🤔

from rebase.

Approvals are kept.

from rebase.

@stefan-enway, no, not if "Dismiss stale pull request approvals when new commits are pushed" is enabled, as stated above.

from rebase.

I would like to make an action for that, as it is not part of actually of the rebase. So if my manager decides that it is worth spending my time on that, I will write one and link it here as well.

from rebase.

@ivandimitrovSC under what circumstances other than rebase would you want to keep approvals? What I'm trying to say is: Keeping approvals is tightly related to the rebase action which would otherwise dismiss approvals (if the above mentioned option is checked). As such, keeping approvals should be implemented as part of this action, and not of another action. Also, this should be configurable: Some user might actually want the rebase to dismiss approvals.

from rebase.

@sschuberth I would just make a reusable piece of code. My point is that approvals should be reapplied only when rebasing automatically. Still, this is not a core functionality to the rebase (git is not GitHub and AFAIK it doesn't have PR requests approval). This might be an option or something else, but IMO it is just nice to have.

from rebase.

Well, I won't be taking this task in a Sprint.

from rebase.

This is more of a github problem than this action. Github won't remove approvers on clean merge commits, but not rebases

from rebase.