Comments (8)
I'm not sure if actions have enough permissions to reinstate the approvals from other users. 🤔
from rebase.
Approvals are kept.
from rebase.
@stefan-enway, no, not if "Dismiss stale pull request approvals when new commits are pushed" is enabled, as stated above.
from rebase.
I would like to make an action for that, as it is not part of actually of the rebase. So if my manager decides that it is worth spending my time on that, I will write one and link it here as well.
from rebase.
@ivandimitrovSC under what circumstances other than rebase would you want to keep approvals? What I'm trying to say is: Keeping approvals is tightly related to the rebase action which would otherwise dismiss approvals (if the above mentioned option is checked). As such, keeping approvals should be implemented as part of this action, and not of another action. Also, this should be configurable: Some user might actually want the rebase to dismiss approvals.
from rebase.
@sschuberth I would just make a reusable piece of code. My point is that approvals should be reapplied only when rebasing automatically. Still, this is not a core functionality to the rebase (git is not GitHub and AFAIK it doesn't have PR requests approval). This might be an option or something else, but IMO it is just nice to have.
from rebase.
Well, I won't be taking this task in a Sprint.
from rebase.
This is more of a github problem than this action. Github won't remove approvers on clean merge commits, but not rebases
from rebase.
Related Issues (20)
- GitHub doesn't think that the PR is rebaseable! HOT 2
- Can we use `equal` function to check the comment intead of `contain` func
- link in README broken HOT 1
- Inconsistency of latest version between GitHub Release and GitHub Marketplace Release
- Do not fail when PR is not rebaseable HOT 1
- Error: /entrypoint.sh: line 63: my_github_username_TOKEN: invalid variable name HOT 3
- GitHub doesn't think that the PR is rebaseable! HOT 7
- README: which permissions required for Personal Access Token?
- Create a new release HOT 2
- Automatically delete comment after rebasing HOT 1
- action is skipped, why? HOT 2
- Checkout repo in a custom path HOT 3
- Minimum level of permissions HOT 2
- Rebase fails in YOLOv5 HOT 1
- Rebase fails on forks
- /entrypoint.sh: line 83: 94dreamer_TOKEN: invalid variable name
- FYI: The official feature is released
- Docker Action run completed with exit code 3
- Cannot rebase because of Github security issue HOT 4
- Workflow defined in readme failing: Required property is missing: runs-on HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rebase.