Comments (17)
@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!
LGTM!! lets wait for reply from @ShreyaPrasad1209
from blog.
@vedant-jain03 we can change Home button from red to green to maintain consistency with the theme. Let's wait for @nitin10s's reply.
@nitin10s what do you think?
from blog.
oh my bad, I was referring to something else. Here what we could do, is completely remove the home button since clicking on the logo anyway directs home. Other than that, the logo fixes look good to me.
Please go ahead and open PR for the same
Thanks for clearing the doubt nitin .
I will just remove the home button and make hover effects on contact only, and add green theme color to them.
give me thumbs up If I am right. I will just make change and raise PR then.
from blog.
@ShreyaPrasad1209 @pavanjoshi914 is it a valid Issue?
from blog.
Navbar size looks appropriate to me. suitable with the theme as the same area is utilized for search and logo. still, you can present your work for an enhanced version of the navbar and we can see what looks more appropriate.
from blog.
Sure @pavanjoshi914 I will give you the sample screenshots within next 3 days and then you can compare which is looking more better.
Thankyou :)
from blog.
@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!
from blog.
@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!LGTM!! lets wait for reply from @ShreyaPrasad1209
Sure
from blog.
@vedant-jain03 we can change Home button from red to green to maintain consistency with the theme. Let's wait for @nitin10s's reply.
@nitin10s what do you think?
Sure I will give green theme color in hover effect
from blog.
@ShreyaPrasad1209 I have done with the edit you have told me to do. Should I raise PR
from blog.
Hey Vedant, that's a nice observation, but why do you want to hide all the nav-links? The nav-links are shown so that the user can take a glance and understand what all we have to offer without clicking anywhere or anything
from blog.
Hey Vedant, that's a nice observation, but why do you want to hide all the nav-links? The nav-links are shown so that the user can take a glance and understand what all we have to offer without clicking anywhere or anything
Actually @nitin10s Their are only 2 navlinks (home and contact), I not hide them, just added hover effect in each as you can see home link with red background.
In additional I have reduced the size of logo to 65%
and also fixes centralization of navbar.
from blog.
What about the nav-links we currently have?
from blog.
What about the nav-links we currently have?
@nitin10s https://blog.circuitverse.org/ in this site I am not able to see nav-links more then home and contact with search and logo. Can you please tell me nitin , where I can see other navlinks?
from blog.
oh my bad, I was referring to something else. Here what we could do, is completely remove the home button since clicking on the logo anyway directs home. Other than that, the logo fixes look good to me.
Please go ahead and open PR for the same
from blog.
One more improvement we need is to change the red colour used to our characteristic green (if you could also fix that issue, in another PR)
from blog.
I have done changes in themes/northendlab-hugo , this is submodule. How can I push my code,?
@pavanjoshi914 @ShreyaPrasad1209 @nitin10s
from blog.
Related Issues (20)
- contact us form taking empty fields HOT 3
- [TYPO]: typo in contact form HOT 6
- [BUG]:contact form submitted successfully without providing any information HOT 1
- [TYPO]:CircuitVerse spelling has 'v' in lower case but it should be 'V' in uppercase HOT 1
- [TYPO]:instead of "Circuitverse" it should be "CircuitVerse" HOT 1
- Bug:The Contact in the footer doesn't highlighted properly HOT 4
- bug:Search in the header should have boundaries HOT 2
- Alignment issues in the navbar of circuitverse Blog page HOT 4
- Changing old logos in the footer HOT 4
- reqeust for changing of twitter logo to new one in Blog footer HOT 3
- 🐞 Bug - Blank Search Functionality HOT 2
- 🐞 Bug - Blank Search Functionality HOT 2
- responsiveness issue HOT 1
- Update twitter logo/icon in footer on blogs page
- fix: footer irrelavent position for search results HOT 3
- Footer `Year` update HOT 7
- CIrcuitVerse logo and description overlapping at a specific breakpoint HOT 1
- Enhancement: The input box is taking too much space for next line content.
- feature: Improve the footer icons
- Feature: Search Bar doesn't look good in the Blog Page and it gets enlarged while scrolled down HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blog.