circleci/[email protected] fails with overwrite: true about circleci-orbs HOT 7 CLOSED

awesome ! will merge this to master 🙂 thank you !! @jams2

from circleci-orbs.

looks like there's some kind of yaml parsing issue where a newline is being inserted where it shouldn't be.... i wonder if we can just make arguments the last portion of the command & that would take care of it...

from circleci-orbs.

You're right (source)

aws s3 sync \
      <<parameters.from>> <<parameters.to>> \
      <<#parameters.arguments>><<parameters.arguments>><</parameters.arguments>><<#parameters.overwrite>> \
      --delete<</parameters.overwrite>>

A newline is being inserted after <<parameters.arguments>>, and it looks like the cause of that, taking my config above:

arguments: |
    --acl public-read \
    --cache-control "max-age=86400"

is the expansion including the unescaped newline after --cache-control. Moving arguments to the end is probably the simplest solution. I can test and throw a PR together some time this week if you like.

from circleci-orbs.

it's such a small change, i can take care of it right now @jams2

i'll merge this change to staging, which will publish a dev version w/ the change, & then, since we're not currently doing any extensive integration or usage testing for orbs in this repo (hard to do in the monorepo—our single-repo orbs are tested much more extensively), can you give your job a shot again with the new dev version ?

from circleci-orbs.

ok, please give this a shot with circleci/aws-s3@dev:staging-71c6a65 @jams2

if that fixes your issue, i'll merge into master, which will trigger the release of a new semantic / production orb version

from circleci-orbs.

That fixes it.

Using config:

version: 2.1
orbs:
  aws-s3: circleci/aws-s3@dev:staging-71c6a65
jobs:
  deploy-staging:
    docker:
      - image: circleci/python:2.7
    working_directory: ~/repo
    steps:
      - run: mkdir syncdir && echo "test" >> syncdir/test.txt
      - aws-s3/sync:
          from: syncdir
          to: 's3://thebloggerprogramme-staging/test2'
          arguments: |
            --acl public-read \
            --cache-control "max-age=86400"
          overwrite: true

workflows:
  version: 2.1
  test_build:
    jobs:
      - deploy-staging

command is expanded as:

    - deploy:
        name: Deploy to S3
        command: |+
          aws s3 sync \
            syncdir s3://thebloggerprogramme-staging/test2 --delete \
            --acl public-read \
          --cache-control "max-age=86400"

and still fine without the overwrite parameter:

    - deploy:
        name: Deploy to S3
        command: |+
          aws s3 sync \
            syncdir s3://thebloggerprogramme-staging/test2 \
            --acl public-read \
          --cache-control "max-age=86400"

Job is here

Thanks!

from circleci-orbs.

fixed in circleci/[email protected] 🎉

from circleci-orbs.