Heroku deploy command does not support maintenance-mode param about circleci-orbs HOT 9 CLOSED

I could see this go either way with maintenance mode being a seperate command as well.

Considering the job and command here have the exact same name, I am leaning on the side it the command supporting the same maintenance mode parameter.

from circleci-orbs.

please give this a shot with circleci/[email protected] @merwok if that doesn't work, feel free to file a new issue describing any bugs you encounter—thanks !!

from circleci-orbs.

feel free to submit a PR—seems like it will be an easy fix @merwok

from circleci-orbs.

ahh, i see @FelicianoTech already did :)

from circleci-orbs.

github is having a webhook problem, so i will attempt to publish the updated version manually @merwok

from circleci-orbs.

Thanks, I will try version 0.0.8.

I have to say that the registry page is rather confusing though (command vs job vs step?) and examples unclear.

from circleci-orbs.

this may help you @merwok

https://circleci.com/docs/2.0/reusing-config
https://circleci.com/docs/2.0/configuration-reference

from circleci-orbs.

I know that quite well, it’s really the 2.1 orb usage that’s not 100% clear :)

from circleci-orbs.

I replaced my custom steps by heroku commands!
It’s not just one line because you still need executor: heroku/default and steps checkout and heroku/install, but it’s pretty great. No more shell commands and YAML reuse, only orbs commands!

(could not use the command directly in the job section of a workflow because I also need slack/status which needs to be a step, and I was not ready to move from one workflow with branch filters on jobs to multiple workflows)

from circleci-orbs.