Currently, the operator will only update the CRD if the running version is smaller tha

I can handle this. I see two options here: A

I think there is a middle ground: introduce a new function <code class="n

As I promised: <a class="issue-link js-issue-link" data-error-text="Failed to load tit

operator: add a flag to force replacing the CRDs about tetragon HOT 4 CLOSED

kkourt commented on September 17, 2024

operator: add a flag to force replacing the CRDs

from tetragon.

Comments (4)

aohoyd commented on September 17, 2024

I can handle this.

I see two options here:

Adding the new arg force bool to

tetragon/pkg/k8s/crdutils/register.go

Line 71 in c1d6f11

func RegisterCRDs(clientset apiextensionsclient.Interface, crds []CRD) error {

. This one is breaking pkg's API and I dont know is this acceptable for you
Adding the new label, something like

CustomResourceDefinitionSchemaOptionForceReplaceKey = ciliumio.GroupName + ".k8s.crd.schema.option.force-replace"

tetragon/pkg/k8s/crdutils/register.go

Line 33 in c1d6f11

const (

. This one is more implicit than the first, but it saves backward compatibility for the library.

Which one do you think works better?

from tetragon.

kkourt commented on September 17, 2024

I think there is a middle ground: introduce a new function RegisterCRDsWithOptions() and pass the options there. This does not break compatibility. RegisterCRD can be marked as deprecated, and eventually removed.

WDYT?

from tetragon.

aohoyd commented on September 17, 2024

I think there is a middle ground: introduce a new function RegisterCRDsWithOptions() and pass the options there. This does not break compatibility. RegisterCRD can be marked as deprecated, and eventually removed.

WDYT?

Great solution! I'll open pr with this change tomorrow

from tetragon.

aohoyd commented on September 17, 2024

As I promised: #2023

from tetragon.

Recommend Projects