Giter Club home page Giter Club logo

Comments (2)

joamaki avatar joamaki commented on June 16, 2024 1

Hey, the direct routing device detection picks the device that has Node IP address assigned on it when there are multiple devices. It seems like in your case it's assigned onto a bridge device. The device detection code however currently ignores bridge devices (this was already the case in v1.14), but the recent change is that now the code to find the device on which the Node IP is assigned to is relying on the detected devices when previously it considered all devices. I would argue this is the correct behavior as a lot of features depend on the correct devices being chosen for datapath use, so it's better to be stricter and require the "--devices" to be specified when the default detection fails.

The other issue here is the crash when the agent is being stopped. This is due to DNSProxy not being properly stopped and it accessing a global variable that was already cleaned up. We'll look into that.
EDIT: Fix for the crash on stop in #32673. I'll look into backport to v1.15 a bit later.

from cilium.

senges avatar senges commented on June 16, 2024

If I remember correctly, 1.14.7 cilium was indeed choosing the bride as direct routing device. You are totally right this was not supposed to be the case, as the node IP was supposed to be taken from another vlan interface.

AFAIK supplying --devices did not work at the time but I'm pretty sure the bridge was also in the list (something like --devices="bridge01,vlan01,vlan02" where vlan01 was holding the right IP). Maybe that's were the issue was coming from.

Thanks for the clarification though ! Again this issue was mostly to report the SIGSEGV in case that wasn't discovered or fixed already, I'm glad everything works as expected then.

from cilium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.