Why this library exposes bunch of globals? about connect-auth HOT 5 CLOSED

Um, what ? Thats the module exports .. I'm a little confused, thats pretty standard in node isn't it ? (they're not global in the 'window' sense of the word)

from connect-auth.

If You don't declare variable it is global even in node. It is accessible from any other module. Try adding 'use strict'; at the beginnings of all files. It will throw an error.

Of course I'm talking about variable names I listed above. No the module.exports, which is standard for node.

from connect-auth.

hmm, interesting. I hadn't appreciated that (or used in for evil purposes) .. that code was re-factored to look like that by a contributor iirc and the pattern isn't used much elsewhere in the library. As it bleeds it should be removed yes I concur.

from connect-auth.

I tell a lie they're everywhere...um sorry.

from connect-auth.

Happily it should be easy to fix that :)
For future I recommend You switching to strict mode. It fixes that stupid JS behaviours.

I wanted to be sure that I'm right here, so I've made little example:

m1.js:

require('./m2.js');
require('./m3.js');
console.log('m1', a);

m2.js:

a = 1;

m3.js:

console.log('m3', a);

And the result for node m1 is:

$ node /www/tests/m1.js 
m3 1
m1 1

So this 'a' variable is accessible even in m3 module.

from connect-auth.