Giter Club home page Giter Club logo

Comments (18)

schenkty avatar schenkty commented on August 11, 2024 1

If the same functionality can be done with a custom controller. that may be the best option. I wouldn't suggest doing a hot fix to just have to fix it again with another iOS change.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024 1

@schenkty Good news. I've managed to get it working on iOS 13. I'm going to publish a new version in the upcoming days.

Bildschirmfoto 2019-07-30 um 22 53 05

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

Hi @schenkty, I haven‘t had the chance to to look into this, yet. But I will try to add iOS 13 support asap. I‘ll keep you in the loop once I‘ve figured out what the issue is. Are you planning to ship an app that is using the lib?

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

@chrs1885 Yes, the app currently has the lib implemented and is working for iOS 12.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

What‘s the name of the app? Is it available on the App Store? Cheers!

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

@chrs1885 not available yet but the app name is called Linkz

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

@schenkty Unfortunately, there doesn‘t seem to be a fix for that right now. However, I‘m pretty sure that this issue will be addressed in the upcoming beta releases. Otherwise, I‘m gonna wrap the color picker inside a custom action sheet controller. Any thoughts on that?

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

What is the issue for it not working? It would probably work fine inside a custom action sheet controller if it has to be in one. I have had issues with other frameworks that use customer action sheet controllers where it doesn't work properly on iPads.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

Exactly. The main reason why I initially decided to go with Apple‘s controller class was to guarantee an expected look&feel/behaviour for all iOS versions. Let‘s give it another beta or two to see if this gets fixed. It seems like that all views inside the action sheet besides the button are simply cut out 😔

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

Can you report the issue to Apple? Maybe they can fix it or suggest the best option moving forward.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

Well, the documentation says that the alert controller is not ment to be customized. Maybe this is on purpose. There seems to be a guy having the same issue: https://stackoverflow.com/questions/56955800/ios13-uialertcontroller-with-custom-view-preferredstyle-as-actionsheet-graysca

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

Presenting the picker inside an alert instead of an action sheet might be a workaround for now.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

I‘m gonna install iOS 13 on one of my testing devices to see if the music app (which also seems to have custom action sheets) can handle the issue properly. If so, I will start to work on a custom controller that immitates the look and feel 😉

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

Sounds great! Thank you for the commitment to this repo, it’s truly awesome.

from sheetycolors.

schenkty avatar schenkty commented on August 11, 2024

That is awesome, congratulations! Does it work the same way as before? How does it work on iPad?

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

It pretty much works the same way as before. Still, the view is based on UIAlterViewController. Didn't check the behavior on an iPad, though.

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

@schenkty This has been added to the develop branch already and is going to be part of the upcoming 1.0.0 release. Feel free to star this repo in case you are happy with it =)

from sheetycolors.

chrs1885 avatar chrs1885 commented on August 11, 2024

@schenkty v 1.0.0 is available. Please let me know, what you are thinking!

from sheetycolors.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.