Comments (18)
If the same functionality can be done with a custom controller. that may be the best option. I wouldn't suggest doing a hot fix to just have to fix it again with another iOS change.
from sheetycolors.
@schenkty Good news. I've managed to get it working on iOS 13. I'm going to publish a new version in the upcoming days.
from sheetycolors.
Hi @schenkty, I haven‘t had the chance to to look into this, yet. But I will try to add iOS 13 support asap. I‘ll keep you in the loop once I‘ve figured out what the issue is. Are you planning to ship an app that is using the lib?
from sheetycolors.
@chrs1885 Yes, the app currently has the lib implemented and is working for iOS 12.
from sheetycolors.
What‘s the name of the app? Is it available on the App Store? Cheers!
from sheetycolors.
@chrs1885 not available yet but the app name is called Linkz
from sheetycolors.
@schenkty Unfortunately, there doesn‘t seem to be a fix for that right now. However, I‘m pretty sure that this issue will be addressed in the upcoming beta releases. Otherwise, I‘m gonna wrap the color picker inside a custom action sheet controller. Any thoughts on that?
from sheetycolors.
What is the issue for it not working? It would probably work fine inside a custom action sheet controller if it has to be in one. I have had issues with other frameworks that use customer action sheet controllers where it doesn't work properly on iPads.
from sheetycolors.
Exactly. The main reason why I initially decided to go with Apple‘s controller class was to guarantee an expected look&feel/behaviour for all iOS versions. Let‘s give it another beta or two to see if this gets fixed. It seems like that all views inside the action sheet besides the button are simply cut out 😔
from sheetycolors.
Can you report the issue to Apple? Maybe they can fix it or suggest the best option moving forward.
from sheetycolors.
Well, the documentation says that the alert controller is not ment to be customized. Maybe this is on purpose. There seems to be a guy having the same issue: https://stackoverflow.com/questions/56955800/ios13-uialertcontroller-with-custom-view-preferredstyle-as-actionsheet-graysca
from sheetycolors.
Presenting the picker inside an alert instead of an action sheet might be a workaround for now.
from sheetycolors.
I‘m gonna install iOS 13 on one of my testing devices to see if the music app (which also seems to have custom action sheets) can handle the issue properly. If so, I will start to work on a custom controller that immitates the look and feel 😉
from sheetycolors.
Sounds great! Thank you for the commitment to this repo, it’s truly awesome.
from sheetycolors.
That is awesome, congratulations! Does it work the same way as before? How does it work on iPad?
from sheetycolors.
It pretty much works the same way as before. Still, the view is based on UIAlterViewController
. Didn't check the behavior on an iPad, though.
from sheetycolors.
@schenkty This has been added to the develop branch already and is going to be part of the upcoming 1.0.0 release. Feel free to star this repo in case you are happy with it =)
from sheetycolors.
@schenkty v 1.0.0 is available. Please let me know, what you are thinking!
from sheetycolors.
Related Issues (14)
- cant install HOT 2
- Dark Mode Support HOT 2
- Add custom action sheet extensions (iOS 13 Support) HOT 1
- Add message label HOT 1
- Support Swift Package Manager HOT 1
- Expose SheetyColors view HOT 1
- HEX-Color input field HOT 1
- Material Action Sheet HOT 3
- Missing import when adding lib via SPM
- Make sliders more accurate
- Breaking layout constraints when using picker inside of a custom container
- Delegate not called when hex value changed (custom container)
- Wrong Hex value displayed after entering Hex code (HSB color space)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sheetycolors.