Giter Club home page Giter Club logo

Comments (2)

ptoulouse avatar ptoulouse commented on August 23, 2024

I have an issue where the log file grew out of control and traced it back to this line of code. The min statement always returns 0. Then max_log_size=0 is passed to the logger. For the logging function, 0 means do not rotate log files.

Edit: Changed min for max as I mistyped it originally (as pointed by @michael-raps below).

from snapraid-runner.

michael-raps avatar michael-raps commented on August 23, 2024

@ptoulouse that is exactly the problem. At the time of this writing

snapraid-runner/snapraid-runner.py

Line 183 in 76af6f7

max_log_size = min(config["logging"]["maxsize"], 0) * 1024
shows the "min" function and not the "max"
In Python the "min()" function returns the smallest value of the provided list of values, which in this case here, will be always 0, no matter what the "config["logging"]["maxsize"]" tells. And with this we don´t get any rotation on the log files.
So it should really be "max(config["logging"]["maxsize"],0)"!

Maybee the owner can have a look? @Chronial ?

from snapraid-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.