[Bug]: "Collection is not created" message despite being returned by list_collections method about chroma HOT 6 CLOSED

@tazarov

Thank you for the provided logs. I reproduced your test with a PersistentClient (with a basic FastAPI implementation) and it works as expected and described by you. Here's a snippet of the code:

import chromadb
client = chromadb.PersistentClient(path=os.path.join(os.getcwd(), "chroma"))
client.get_or_create_collection("Test")

Logs:

INFO:     Application startup complete.
INFO: Anonymized telemetry enabled. See https://docs.trychroma.com/telemetry for more information.
INFO:     127.0.0.1:53838 - "POST /api/v1/test HTTP/1.1" 200 OK
INFO: Collection Test is not created.
INFO:     127.0.0.1:33750 - "POST /api/v1/test HTTP/1.1" 200 OK

When I test it with the code from the initial issue, I get the info message no matter if the collection exists or not. I guess the problem is someplace else. I will update this comment (or write a new one) if I find where the problem is.

Thank you for the fast replies and for your time!

from chroma.

Hey @hoosengold, thanks for pointing this out. This is just an info-level log message used for tracking the behavior of the get_or_create_collection() function semantics. It just lets you know that the call did not create a new collection but returned an existing one. I can see how this exact phrasing can be misleading and interpreted as an error.

Let us improve on the messaging.

from chroma.

Hi @tazarov, thank you for the fast reply!

It just lets you know that the call did not create a new collection but returned an existing one.

It seems like the message is always displayed, not just when getting the collection but also when creating it. That means that the created bool variable is always set to False by the _sysdb.create_collection() method for some reason. I hope that this does not indicate a more complex problem.

However, thanks again for the quick response and fixing the info message!

from chroma.

Thanks for this insight, @hoosengold. I will have a look in sysdb and fix that if necessary.

from chroma.

@hoosengold,

I just tested with:

import chromadb

client = chromadb.HttpClient()

client.get_or_create_collection("Test")

Results:

INFO:     [15-05-2024 13:57:01] Application startup complete.
INFO:     [15-05-2024 13:57:01] Uvicorn running on http://localhost:8000 (Press CTRL+C to quit)
INFO:     [15-05-2024 13:57:09] ::1:50449 - "GET /api/v1/tenants/default_tenant HTTP/1.1" 200
INFO:     [15-05-2024 13:57:09] ::1:50449 - "GET /api/v1/databases/default_database?tenant=default_tenant HTTP/1.1" 200
INFO:     [15-05-2024 13:57:09] ::1:50450 - "POST /api/v1/collections?tenant=default_tenant&database=default_database HTTP/1.1" 200
INFO:     [15-05-2024 13:57:17] ::1:50453 - "GET /api/v1/tenants/default_tenant HTTP/1.1" 200
INFO:     [15-05-2024 13:57:17] ::1:50453 - "GET /api/v1/databases/default_database?tenant=default_tenant HTTP/1.1" 200
DEBUG:    [15-05-2024 13:57:17] Collection Test already exists, returning existing collection.
INFO:     [15-05-2024 13:57:17] ::1:50454 - "POST /api/v1/collections?tenant=default_tenant&database=default_database HTTP/1.1" 200

As expected, the message was returned only when trying to get_or_create_collection() on an existing collection. The initial creation (INFO: [15-05-2024 13:57:09] ::1:50450 - "POST /api/v1/collections?tenant=default_tenant&database=default_database HTTP/1.1" 200) of the collection did not trigger the message.

from chroma.

Closing this for bug hygiene. Feel free to create another issue if you find another issue.

from chroma.