Giter Club home page Giter Club logo

Comments (11)

chriswalz avatar chriswalz commented on May 16, 2024

@Hultner Thanks for filing this issue. Agreed that bit can be difficult to read in some contexts. Currently, I'd like to avoid config files if possible.

One option is to have "absolute" colors that don't change due to the background however AFAIK that's not possible with https://github.com/c-bata/go-prompt.

Another option is to have two themes a light & dark them that changes based on the terminal background color. Surprisingly this isn't possible with all terminals AFAIK.

from bit.

Hultner avatar Hultner commented on May 16, 2024

A popular tool with "pretty" syntax that handles this quite nicely is bat1, they use a $BAT_THEME environment variable which in my opinion is much nicer than a configuration file. They also have built in support of base16.

I'm not very familiar with go but a quick search turned up this library, might not be useful but I'll leave it here anyway.

from bit.

chriswalz avatar chriswalz commented on May 16, 2024

I've added an experimental "inverted" theme. To enable set your env variable:

BIT_THEME=inverted

from bit.

Hultner avatar Hultner commented on May 16, 2024

@chriswalz Is this released yet? it still looks just as bad, just slightly different on bit v0.8.2
image

from bit.

chriswalz avatar chriswalz commented on May 16, 2024

Here's what I see

bit --version
bit version 0.8.2

image

image

image

image

from bit.

chriswalz avatar chriswalz commented on May 16, 2024

I guess on your end it's the "Selected" color that is problematic. It's possible some colors aren't getting set

from bit.

Hultner avatar Hultner commented on May 16, 2024

I've never coded go but I might be able to give it a go and see if I can create something reasonable looking if the build tool chain is easy/fast to set up. Tell me if that would be appreciated.

from bit.

chriswalz avatar chriswalz commented on May 16, 2024

Yes, definitely take a look. Look for the function SuggestionPrompt( in util.go.

Once you clone or fork the repo & install go. run BIT_THEME=inverted go run main.go

from bit.

Hultner avatar Hultner commented on May 16, 2024

@chriswalz I gave it a go (some Gothenburg humour right there), I made two themes to compare, I think it might turn out better this way since it's not always the same theme that works everywhere. Anyway here's a first screenshot. I took them with night shift on at first so I'm redoing the other colour themes without to give a good picture of how it looks.

The inverted one is more inspired by the original theme, while the monochrome one is just a brutalist minimalist approach and simply uses the defaults.
Screenshot 2020-10-29 at 21 23 42

from bit.

Hultner avatar Hultner commented on May 16, 2024

Okay here's a full load of screenshots, I didn't test everything but at least of these two additional themes is readable on every combination I've tried, a good dozen of teams seems reasonable.

Screenshot 2020-10-29 at 21 23 42,
Screenshot 2020-10-29 at 21 23 29
Screenshot 2020-10-29 at 21 23 22

.
Screenshot 2020-10-29 at 21 23 17
Screenshot 2020-10-29 at 21 31 17
Screenshot 2020-10-29 at 21 30 30
Screenshot 2020-10-29 at 21 30 25
Screenshot 2020-10-29 at 21 29 41
Screenshot 2020-10-29 at 21 28 56
Screenshot 2020-10-29 at 21 27 44
Screenshot 2020-10-29 at 21 27 30
Screenshot 2020-10-29 at 21 34 32

Screenshot 2020-10-29 at 21 34 21

from bit.

Hultner avatar Hultner commented on May 16, 2024

@chriswalz Added a PR #71

from bit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.