Giter Club home page Giter Club logo

Comments (3)

chrisrhymes avatar chrisrhymes commented on May 20, 2024

Hi @Niek. I would like to keep the theme compatible with GitHub pages and it looks like that is still using Jekyll 3.8 according to the runtime dependencies: https://rubygems.org/gems/github-pages

from bulma-clean-theme.

Niek avatar Niek commented on May 20, 2024

Makes sense, thanks for explaining!

from bulma-clean-theme.

eheinrich avatar eheinrich commented on May 20, 2024

Hi @chrisrhymes, I'm starting a new Jekyll site and would love to use this theme, it looks great! The site that I'm starting will not be deployed on GitHub Pages, and I would like to use Jekyll v4. I wanted to check in on this issue since it's been a couple years since it's been updated. Have plans to allow the theme to work with Jekyll v4 changed during that time? I understand that that effort has been blocked on the GitHub Pages gem not supporting it yet, and that you want to keep the theme compatible with that gem, but this issue makes it seem like they won't be updating to Jekyll v4 any time soon (or at all? it's unclear...).

As part of this, I was wondering if you would be open to updating the version range of Jekyll in this project's gemspec to something like spec.add_runtime_dependency "jekyll", ">= 3.9", "< 4.3.0"? That way, for people like me who are not deploying to GH Pages, or for those who are using GH Actions instead of the GH Pages gem to deploy their site to GH Pages, a newer version of Jekyll can be used. And for those that are using the GH Pages gem, the dependency should resolve to 3.9. To check if this theme would work with v4, I cloned this repo, updated the gemspec as described, and ran the hot reload server. Just from some quick preliminary testing, the site seemed to work as I would expect using Jekyll version 4.2.1.

from bulma-clean-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.