Comments (7)
Hello!
I want to use your library as a dependency for my library, but there was a bug in this lib.
So i fixed it and made PR.
Please check it #17
from string-calc.
Thanks for your answer and for the great library (sorry if i sounded too cold on my first message but i was in a hurry). Is there anything i can do to help? Not sure i am knowledgeable enough to make a pull request
from string-calc.
If you have any idea how to fix this issue do not hesitate to let me know :) I will try to find a solution on my own but I do not know when I will be able to do so - I'm quite busy these days.
from string-calc.
i have noticed, by debugging, that it tries to analyze the "-" symbol by itself and in this case isUnaryOperator
is false so it enters in the else
branch
from string-calc.
Hello, I will investigate.
from string-calc.
Test code: 15cb960
Test result: https://travis-ci.org/chriskonnertz/string-calc/builds/447489420?utm_source=github_status&utm_medium=notification
Failing.
So it seems you are right. Unfortunately ;)
from string-calc.
Hello prohalexey,
thank you for your contribution! Great to see you could find the spot where the issue is located and write an update that fixes it. Good work, thank you.
I've merged your pull request and will create a new release with it.
from string-calc.
Related Issues (15)
- Wrong calculations HOT 4
- Adding custom symbols doesn't work (internal symbol container issue) HOT 4
- Singleton pattern implementation incorrect
- [Question] Does it use default php float math or decimal math, when operating on floats? HOT 2
- [Improve] use token_get_all instead of tokenize method HOT 2
- Logical operators HOT 1
- [Enhancement] Add more test calculations HOT 1
- Is it possible to add custom functions? HOT 1
- Problem calcul simple sum HOT 2
- Problem calcul simple sum HOT 1
- Using x as * (multiplication) HOT 1
- Modulo HOT 5
- Percentage calculations HOT 2
- Division by 0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from string-calc.