Comments (6)
I am not sure if this test case is trivial as well.
Guess the idea is to test a string that causes trouble with the current implementation but will not with the updated, right?
from open-graph.
Yep, that's right.
from open-graph.
Code: a2ebbd8
from open-graph.
Test: https://github.com/chriskonnertz/open-graph/blob/mb_substr/tests/OpenGraphTests.php#L95 (green)
from open-graph.
Are you ok with that?
from open-graph.
Looks good although it should be reading the text back from the opengraph object, of course
from open-graph.
Related Issues (20)
- Semver support HOT 2
- Are keywords supported? (no, because OGP does not support it) HOT 3
- REQUEST URI not set HOT 7
- TODO: Remove whitespace HOT 1
- title not found HOT 8
- Not working HOT 7
- ToDo: Use typed param in localeAltenate() method
- asset($imageFile) function HOT 2
- Call to undefined method ChrisKonnertz\OpenGraph\OpenGraph::attributes() HOT 6
- Write unit test for attributes()
- Video with attribute leads to error HOT 2
- OpenGraph::convertDate may return not string
- PHP 8
- composer.json HOT 2
- Warning OpenGraph::$title is deprecated
- Todo: Laravel 5 Readme Update HOT 1
- renderTags method should not be escaped in templates HOT 2
- Generates og:article:XXX rather than article:XXX HOT 3
- Could change to support Carbon dates too HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-graph.