Giter Club home page Giter Club logo

Comments (3)

chrisjbryant avatar chrisjbryant commented on May 20, 2024 2

That's a good idea and something I've vaguely thought about before, but I'll definitely add it to my list of enhancements.
You're also right that it hopefully shouldn't involve too much refactoring. I'll take a look in the next couple of days and see how it goes!

from errant.

Mindful avatar Mindful commented on May 20, 2024 2

I hadn't thought of using subprocess - that's a good point, although you're right that it's pretty ugly.

In terms of a PR, to be honest I was going to try and change as little as possible, by just refactoring the existing code slightly so that there was some kind of entry point function and a way to get the output as a dict of strings. I think what you're suggesting with the Edit objects probably makes more sense, so I'm not sure it's worth me producing a hacky PR. If I end up with extra time on my hands I'll give a rewrite using Edit objects a try and send you that as a PR, but it's also likely not anything I can do soon.

Fortunately I don't urgently need this, so it's enough for me if one of us gets to it at some point. If I find time and start working on a PR I'll post another comment so we don't end up doing the same work twice; otherwise, if/when you get to it I'll try to be your first user.

from errant.

chrisjbryant avatar chrisjbryant commented on May 20, 2024

Hmm, having looked into it and thought about it a bit more, I think it will require a bit more work than I anticipated.

The evaluation script is currently a standalone script that stores edits as lists, but I would probably want to convert them to Edit objects for full integration into ERRANT; otherwise it seems messy to compare hypothesis Edit objects against reference edit lists (or not use Edit objects at all). That's something I can still do, but it will require changing almost all the eval functions, so don't expect anything soon!

In the mean time, feel free to work on something yourself and submit a PR. I can't promise I'll accept it, but it should at least give me a better idea on how to implement this in the future. Alternatively, you could also try running errant_compare as a subprocess and then processing the stdout. It's ugly, but it should work.

from errant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.