Giter Club home page Giter Club logo

Comments (3)

drewbrokke avatar drewbrokke commented on June 28, 2024 1

Thanks for the response, @ChrisCarini.

I can see a case for either one here, as each approach has advantages. muteRules would be a more straightforward API, but cliArgs gives that maximum future-facing flexibility.

Regarding cliArgs, since the entry for inputs would just be a string, we might be getting into tricky arg-parsing territory here ("is this space inside quotes or not?"), which may be more trouble than it's worth.

I'll give it a shot. For speed's sake, let's start with mute/muteRules. Sound ok?

from intellij-platform-plugin-verifier-action.

ChrisCarini avatar ChrisCarini commented on June 28, 2024

Hi @drewbrokke,

First off, thank you for using this GitHub Action and opening this feature request!

The muteRules option reminds me of failure-levels (implemented in cc63b2c) and is explicit, whereas cliArgs seems like it would be more flexible (e.g. if a similar CLI argument was added to the verifier in the future).

Either solution to the problem seems reasonable to me - is there one you'd recommend over the other? Also, are you interested in having a go at the implementation?

Best,
Chris

from intellij-platform-plugin-verifier-action.

ChrisCarini avatar ChrisCarini commented on June 28, 2024

Yeah, I agree with your assessment.

I'll give it a shot. For speed's sake, let's start with mute/muteRules. Sound ok?

SGTM!

from intellij-platform-plugin-verifier-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.