Seems that the resampler is not working about opus-recorder HOT 13 CLOSED

Opus doesn't support 44100 internally. I'm guessing that the rate 44100 you
see is the decoded data sample rate for playback. If you attach a sample
file I can take a look at it.

On Sun, 6 Nov 2016 at 14:34 Rotem [email protected] wrote:

Hi,
I'm streaming from recorderjs to node-opus.
On the server when I read the header file it seems like it is still
44100.I also tried to run opusinfo, and still it is 44100.
Do I miss anything?

this is how I use it on the client:

var rec = new Recorderjs.Recorder({
encoderPath:'libs/recorderjs/encoderWorker.min.js',
streamPages:true,
encoderSampleRate:48000
});

On the server, using node-opus I do:

var oggDecoder = new ogg.Decoder();
var opusDecoder=null;
var wavWriter = null;
var fsOpus = fs.createWriteStream(opusFile);
oggDecoder.on('stream',function (oggStream) {
opusDecoder = new opus.Decoder();
opusDecoder.on('format', function (format) {
console.log(format);
wavWriter = new wav.FileWriter(pcmFile, {
channels: format.channels,
sampleRate: format.sampleRate,
bitDepth: format.bitDepth
});
opusDecoder.pipe(wavWriter);
});
oggStream.pipe(opusDecoder);

        })
        stream.pipe(oggDecoder);
        stream.pipe(fsOpus);

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#60, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe7gw4MeoEuznIPtcfCn55ZBmcziSPfks5q7ivTgaJpZM4KqpxP
.

from opus-recorder.

Sure,
Thank you!
See attached.
in.opus.txt

from opus-recorder.

This is the opusinfo output for your file. What part about this doesn't look right to you?

New logical stream (#1, serial: f07d0bd4): type opus Encoded with Recorder WARNING: EOS not set on stream 1 (normal for live streams) Opus stream 1: Pre-skip: 3840 Playback gain: 0 dB Channels: 1 Original sample rate: 44100Hz Packet duration: 20.0ms (max), 20.0ms (avg), 20.0ms (min) Page duration: 3700.0ms (max), 3700.0ms (avg), 3700.0ms (min) Total data length: 23777 bytes (overhead: 1.31%) Playback length: 0m:03.620s Average bitrate: 52.55 kb/s, w/o overhead: 51.86 kb/s

from opus-recorder.

Original sample rate: 44100Hz means that the original audio had a bandwidth of 44100Hz. Judging from your code snippets, it was then up-sampled to 48000Hz for encoding with opus. This all looks as expected.

from opus-recorder.

I'm getting an error from node-opus (Maybe it related to node-opus)
Error: Could not create decoder. Check the decoder parameters
When looking into node-opus code, it seems like it sends the header sampleRate to the opus decoder, and opus decoder does not support it.
Any idea what's going on? If for example I modify the code and hard code 48000, it works.

from opus-recorder.

Yeah, seems that node-opus is using the header defined sample rate to try and decode. I opened an issue here: Rantanen/node-opus#20

from opus-recorder.

Ok. Thanks,
Still, if I try to play the file after the decoding.. it different (like slower..)

from opus-recorder.

Likely because you are decoding at 48000 Hz and then playing it back at 44100Hz without resampling?

from opus-recorder.

Ok, so I need to downsample it then... Thank you for the help. Do you know if there is a library that downsample?

from opus-recorder.

Lots of them. Easiest would probably be to pipe your output to SOX.
Never tried this, but it might do the trick: https://www.npmjs.com/package/sox

from opus-recorder.

Ok,
Thank you!
I think we should close this issue as it is not related to recorderjs.

from opus-recorder.

See my pull request on node-opus:
Rantanen/node-opus#21

Hope that should solve it.

from opus-recorder.

Cool. 👍

from opus-recorder.