driver.go: mssql semicolon delimited string format about sql-agent HOT 7 CLOSED

For context, I'm trying to get this working with your other great prometheus-sql project!

from sql-agent.

Hi @simonwillcock! Thanks for the report, it looks like you are correct per the driver documentation. I don't have an SQL Server database to test against, but I patched the code and pushed a new docker image with a commit tag:dbhi/sql-agent:1fcc067 Can you pull it down and give it a try?

from sql-agent.

Awesome, thanks! I should be able to give it a crack tomorrow and report back :)

from sql-agent.

Ok that worked well! Thanks for making that change so quickly.

However, I found a couple of other issues related to the connection parameters that the go-mssqldb lib is expecting compared to the set of parameters that prometheus-sql has documented.

I think the same function above should probably map the documented parameters to those expected by the the go-mssqldb library as follows:

• host -> server
• user -> user id

Fortunately your project just passes through all the parameters, so I could just specify the alternate keys in the .yml file, but for consistency it would probably make it easier for future users to map them automatically!

Thanks again for this project and for responding so quickly for the issue above! Let me know if you want me to move this to a new issue or not.

from sql-agent.

Thanks for debugging this 😄 Here is the latest build dbhi/sql-agent:2f937ce which includes this mapping.

from sql-agent.

Hey bruth, sorry for the delay. I've just given this a run using the default user and host parameters in the .yml, and it works a treat! 👍

from sql-agent.

Great! No problem at all. I will push out releases in a bit.

from sql-agent.