Giter Club home page Giter Club logo

Comments (2)

zhang-ivy avatar zhang-ivy commented on June 18, 2024

Iván notes that this is not super high priority since we are in the midst of overhauling the API anyway

from perses.

ijpulidos avatar ijpulidos commented on June 18, 2024

Yes,the comment on

perses/perses/app/relative_setup.py

Line 329 in ae55801

# We must generate the complex topology and positions before the SystemGenerator is created because if the
explains why we needed that at that instance but, as discussed, we can quickly investigate what happens if we remove the second call, since that seems redundant and it shouldn't be doing anything new.

As a reference, when I worked in the refactor for the NEQ cycling protocol, the RelativeFEPSetup.__init__ method of is more organized and it's only setting up the phases at the end of it, as per

perses/perses/app/relative_setup.py

Line 349 in faac030

self._setup_phases(
(just to keep in mind).

from perses.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.