"failed to write cache: key must be a string" on comments containing "::" about vimwiki-rs HOT 5 CLOSED

Additionally, noting explicitly that it feels a little weird that comments render as empty paragraphs:

Input:

== comments ==

%% this is a comment

%% another comment

Output:

<div id="comments"><h2 id="comments" class="header"><a href="#comments">comments</a></h2></div>
<p></p>
<p></p>

Or I guess maybe the blank lines between the comments render as empty paras?

== comments ==
%% this is a comment
%% another comment

Gives:

<div id="comments"><h2 id="comments" class="header"><a href="#comments">comments</a></h2></div>
<p> </p>

from vimwiki-rs.

I should revise html output of empty paragraphs to be nothing.

Separately, comments are supposed to be the first thing processed when it comes to inline content. I'll have to write up some tests based on your examples and figure out what's up.

Thanks for these!

from vimwiki-rs.

I think 35498bf solves the "key must be a string" error. Those should never be a true problem, by the way, as it just prevents caching from happening but not the actual conversion to html.

As for the comment becoming a definition list, I think I'll need to revise the parser a little bit. Definition list has higher priority than paragraph and the term (what comes before ::) allows pretty much any character including %%; so, I think it's eating the comment.

from vimwiki-rs.

@brennen give d339b69 a go to see if that fixes the issue.

from vimwiki-rs.

No more error message and the comments aren't rendered as definition lists, looks good!

from vimwiki-rs.