Comments (6)
There's also "prior art" for what happens with the choice of banning the trailing comma with JSON, and it makes JSON annoying to edit directly. JSON5 (http://json5.org/) updates the JSON spec to allow trailing commas among other extensions.
from cookstyle.
no, cookstyle is a set of choices that we've made for cookbook development.
You should not run both cookstyle and rubocop, because they make different choices.
from cookstyle.
dup of #21 as well.
not sure why this isn't totally obvious that this is the whole idea... README.md needs to be a little more brutally clear about the point?
from cookstyle.
@lamont-granquist @thommay thank you
Choosing cookstyle or rubocop (not both) is clear.In programming the reason behind the choice keeping a comma at the end of a hash which cookstyle suggests, is not clear.
from cookstyle.
The reasons for the trailing comma are twofold:
- It makes adding lines, and moving lines, safe. You don't have to think about whether you added a trailing comma to the line you moved, or the line above the one you added, you just write the line and finish with a comma, always
- it makes diffs easier to read, since you just see the line you added, not that line and the line before
from cookstyle.
There's also other differences like e.g. #18
from cookstyle.
Related Issues (20)
- Detect using run_action on the resource block to force compile_time
- Avoid ternary operator in properties HOT 1
- Alert on more uses of mixlib::shellout
- Resource property descriptions shouldn't end with a space
- Don't set empty property descriptions
- remote_file: using a not_if to check if the file doesnt' already exist HOT 1
- Detect single line do/end style blocks
- Detect the usage of chef-sugar
- Conditional use of `unified_mode true` needs to warn HOT 1
- Chef/Modernize/CronDFileOrTemplate fails to flag matching resources that use string interpolation HOT 1
- Chef/Deprecations/Delivery triggers without dot-delivery directory existing HOT 5
- Chef/Modernize/CronDFileOrTemplate fails to match when the path property is used to provide the file path
- Chef/Modernize/CronDFileOrTemplate matches on /etc/cron.deny HOT 2
- Chef/Modernize/CronDFileOrTemplate triggers on cron.daily
- Error: unrecognized cop or department {{cop}} found in {{global vanilla rubocop config}}
- Chef/Modernize/CronDFileOrTemplate causes RuboCop error on non-cron file resources HOT 1
- Chef/Correctness/LazyEvalNodeAttributeDefaults does not detect nested attributes
- RuboCop URL in README uses http://rubocop.org
- Cookstyle configuration "streams" HOT 1
- Warning: AllCops does not support TargetChefVersion parameter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cookstyle.