git provider: can not shallow clone from a branch about chef HOT 11 CLOSED

Ran into this recently when testing deploys on ubuntu 14.04, seems the issue arose when git learnt the --single-branch flag in 1.7.10 and the default behaviour changed. The most recent git package on 12.04 was 1.7.9 so we'd never run into the issue there.

Your suggestion fixes the initial deploy, but if the next deploy switches branch you run into the same issue. I think the flag to use is --no-single-branch which ensures you get the tip of all current branches which I believe was standard git behaviour prior to git 1.7.10. Unfortunately, because that flag doesn't exist in versions prior to that, there likely needs to be some git version detection to avoid breaking deploy for machines still using old version of git.

from chef.

@vitaliel thanks for the issue. Would be great if you can take a stab at adding the additional parameter for -b branch_name. Let us know if you need some pointers to get started.

from chef.

Any update on this?

from chef.

Anyone have a suggested workaround for this issue, given i have several cookbooks we use to deploy code internally that are broken by this bug.

from chef.

You can work around in the short term with shallow_clone false, your deploy will take longer, but it mitigates the problem. Obviously depending on the size of the repo in question, this may or may not be viable.

The more hardcore solution is a total hack; works by monkey patching the resource to inject the necessary switch. However be warned this will break deploys on any machine using a version of git prior to 1.7.10. If you're happy with that you should be able to create an rb file in your cookbook's libraries directory containing:

class Chef
  class Resource
    class Deploy < Chef::Resource
      def depth
        @shallow_clone ? "5 --no-single-branch" : nil
      end
    end
  end
end

You might need to play with that a bit as I only gave it a cursory test a month or so ago and just rewrote it from memory.

P.S. You could probably add some version check conditional to the hack if you need to support older git versions.

from chef.

Thanks! that almost worked, with a small tweek i got something that gets me out of this bind until a better solution is found!

class Chef
  class Resource
    class Deploy < Chef::Resource
      def depth
        if node[:platform_version].to_i  >= 14.04 && node[:platform] == "ubuntu"
          @shallow_clone ? "--depth 5 --no-single-branch" : nil
        end
      end
    end
  end
end

from chef.

Has a official fix for this issue been identified? As a side note the fix above works great for simple cookbooks, however on a more complex cookbook, with a non default.rb recipe this fix seems to fail.

from chef.

Any idea of the priority of this?

from chef.

based on the lack of response I'm going to guess opscode is not going to fix this

from chef.

@neallawson Fixed in master.

from chef.

@randomcamel Thank You! this will make my life much easer!!!!

from chef.