CHEF-2707 subversion resource doesn't work on windows about chef HOT 13 CLOSED

Thanks for getting this into here @cixelsyd.

We've seen similar issues where using popen4 is creating some issues on windows. I think the right path here would be to switch using shell_out instead of output_of_command to execute the command.

The conversion should be pretty straightforward. If you'd like to make a shot at this let me know and I'll give you some pointers to get you started.

Thanks again for spending time and working with us on this.

from chef.

I'm excited to work with you on this. let me know how I can help!

Steven

mobile

On Jun 24, 2014, at 4:21 PM, Serdar Sutay [email protected] wrote:

Thanks for getting this into here @cixelsyd.

We've seen similar issues where using popen4 is creating some issues on windows. I think the right path here would be to switch using shell_out instead of output_of_command to execute the command.

The conversion should be pretty straightforward. If you'd like to make a shot at this let me know and I'll give you some pointers to get you started.

Thanks again for spending time and working with us on this.

—
Reply to this email directly or view it on GitHub.

from chef.

Awesome @cixelsyd. shell_out() is the Chef's platform independenct command execution system which takes care of a lot of the nasty stuff. We need to replace the output_of_command functions with shell_out calls in the lib/chef/provider/subversion.rb file.

You can see a really good example here: https://github.com/opscode/chef/blob/master/lib/chef/provider/git.rb#L123

LMK if you have any questions or help to move forward and thanks so much for spending your time on this 😄

from chef.

has this been fixed already? or is there any workaround for it? I have this same problem. Thanks in advance!

from chef.

As a workaround for this bug i did the following,

1. Create a file in libraries folder of a cookbook that is presenting the error or one that you always include in your runlists

2. Into that file, add the following code:

   class Chef
     module Mixin
   
       module Command
         extend self
   
         def handle_command_failures(status, command_output, opts={})
           unless opts[:ignore_failure]
             opts[:returns] ||= 0
             unless Array([opts[:returns],42]).include?(status.exitstatus)
               # if the log level is not debug, through output of command when we fail
               output = ""
               if Chef::Log.level == :debug || opts[:output_on_failure]
                 output << "\n---- Begin output of #{opts[:command]} ----\n"
                 output << command_output.to_s
                 output << "\n---- End output of #{opts[:command]} ----\n"
               end
               raise Chef::Exceptions::Exec, "#{opts[:command]} returned #{status.exitstatus}, expected #{opts[:returns]}#{output}"
             end
           end
         end
   
         module Windows
           def popen4(cmd, args={}, &b)
   
             # By default, we are waiting before we yield the block.
             args[:waitlast] ||= false
   
             #XXX :user, :group, :environment support?
   
             Open3.popen3(cmd) do |stdin,stdout,stderr,cid|
               if b
                 if args[:waitlast]
                   b[cid, stdin, stdout, stderr]
                   # send EOF so that if the child process is reading from STDIN
                   # it will actually finish up and exit
                   stdin.close_write
                 else
                   o = StringIO.new
                   e = StringIO.new
   
                   stdin.close
   
                   stdout.sync = true
                   stderr.sync = true
   
                   line = stdout.gets(nil)
                   if line
                     o.write(line)
                   end
                   line = stderr.gets(nil)
                   if line
                     e.write(line)
                   end
                   o.rewind
                   e.rewind
                   b[cid, stdin, o, e]
                 end
               else
                 [cid, stdin, stdout, stderr]
               end
             end
   
             `ls` if $?.nil?
             Chef::Log.debug ". : : : $? returned nil for command #{cmd}  : : : ."
             $?
           end
   
         end
   
       end
     end
   end
   

the lines that do the trick are:

unless Array([opts[:returns],42]).include?(status.exitstatus)

and

`ls` if $?.nil?
Chef::Log.debug ". : : : $? returned nil for command #{cmd}  : : : ."

(of course, you can erase the debug printing if you want to)

that way you don't need to fix something for every chef release if it's not fixed yet.

I hope it's useful for someone else.

from chef.

It'd be better to get a PR that just replaced the commands with mixlib-shellout

from chef.

Thanks @jgutierrezc. This work very well for me.

from chef.

Should have been fixed by 7b26c36 and prior commits

from chef.

(should be fixed in 12.1.0)

from chef.

This code:

subversion 'couchdb' do
  repository 'http://svn.apache.org/repos/asf/couchdb/trunk'
  revision 'HEAD'
  action :sync
end

run with: chef-apply svn.rb -l debug fails at line https://github.com/chef/chef/blob/master/lib/chef/provider/subversion.rb#L133:

status, svn_info, error_message = output_of_command(command, run_options)

because output_of_command is still trying to access status.exitstatus

I'll put this on my work backlog to replace output_of_command with shell_out!, but I'm unlikely to whack this off soon.

EDIT: I forgot to mention: This is a Windows issue

from chef.

I just ran into this in exactly the way @pburkholder mentioned. Can this issue be reopened?

from chef.

The above PR fixes this for me.

from chef.

this looks like it got fixed

from chef.