chef_client_updater always schedules update when product_name chefdk about chef_client_updater HOT 5 CLOSED

I believe I am seeing this issue also. Trying to test this in kitchen and it just sits in an infinite loop of updating.

BTW I am on Linux not Windows, so this doesn't appear to be isolated to the Windows platform.

The issue lies here:

[2018-04-02T16:13:32+00:00] DEBUG: The current chef-client version is 13.8.5 and the desired version is 2.5.3
[2018-04-02T16:13:32+00:00] DEBUG: A chef-client upgrade is necessary

It is detecting the chef-client version bundled inside of chefdk instead of the actual chefdk version.

from chef_client_updater.

More info:

ohai chef_packages
[2018-04-02T16:17:02+00:00] INFO: The plugin path /etc/chef/ohai/plugins does not exist. Skipping...
{
  "chef": {
    "version": "13.8.5",
    "chef_root": "/opt/chefdk/embedded/lib/ruby/gems/2.4.0/gems/chef-13.8.5/lib"
  },
  "ohai": {
    "version": "13.8.0",
    "ohai_root": "/opt/chefdk/embedded/lib/ruby/gems/2.4.0/gems/ohai-13.8.0/lib/ohai"
  }
}

This seems like it will only work for chef-client rather than both chef-client and ChefDK:
https://github.com/chef-cookbooks/chef_client_updater/blob/master/providers/default.rb#L105-L107
https://github.com/chef-cookbooks/chef_client_updater/blob/master/providers/default.rb#L133-L142

from chef_client_updater.

nice investigation @bkonick - I concur that the current_version method is likely the easiest thing to change to something like:

def current_version
  node['chef_packages'][new_resource.product_name]['version']
end

from chef_client_updater.

Thanks @irvingpop! .. I'll play around with that function and see what I can come up with.

Seems like an easier way to go is use actual OS package names rather than this which appears to be looking at the gem. Given that the statement in the readme is support of all platforms with a chef-client package download that might work?

from chef_client_updater.

You're right, I think the Ohai packages provider may be more reliable for that.

from chef_client_updater.