Comments (4)
@joe-vortex thanks from your message. We haven't managed to reproduce this error on a default setup. Please check the screenshot below to see that the console is clean and Frames displaying properly.
Could you please provide more information on your specific context and/or on how to reproduce this?
from checkout-magento2-plugin.
Hey @david-fiaty-cko, my apologies, I found there was an override in my theme, preventing the embedded url from showing outside the checkout. It works without that override. However I would still point out that for performance purposes my PR should still be considered so that the script is not render blocking. including script tags in a template is not in keeping with magento best practices.
from checkout-magento2-plugin.
@joe-vortex, thanks for your message. We are working on a new version of the module that will consider your observations.
The current release is stable. It's preferable not to add changes not addressing an issue that will require additional testing and maybe impact other merchants. Thank you.
from checkout-magento2-plugin.
sure, thanks for taking the time to consider my suggestion.
from checkout-magento2-plugin.
Related Issues (20)
- Performance issue on checkout page. HOT 3
- Save Card 422 Error code HOT 1
- Cannot default payments to base currency
- v5.0 update - The API response status code (401) does not indicate success HOT 2
- Hyva Compatibility
- Webhook receives payment info but no order was created HOT 4
- API Refunds Erroring. HOT 1
- Incorrect payment method saving for orders
- Webhook is not getting the store_id from the request. HOT 1
- Failed payments result in orders completing successfully HOT 1
- Place order button disabled after failing a payment
- order_action_failed_payment is Null if config is default
- 400 errors on /customer/section/load/?sections=cart
- An error has occured, Please select another payment method
- Last module don't handle payment_declined HOT 1
- Last module don't handle Log error
- Error on rendering Checkout page HOT 1
- Apple Pay script needs to check if client SUPPORTS v14 HOT 3
- Apple Pay payment not working HOT 3
- Model\Api\V3::processPayment method is broken. Using array as object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from checkout-magento2-plugin.