Giter Club home page Giter Club logo

Comments (4)

david-fiaty-cko avatar david-fiaty-cko commented on July 17, 2024

@joe-vortex thanks from your message. We haven't managed to reproduce this error on a default setup. Please check the screenshot below to see that the console is clean and Frames displaying properly.
Could you please provide more information on your specific context and/or on how to reproduce this?

frames-integration

from checkout-magento2-plugin.

joe-vortex avatar joe-vortex commented on July 17, 2024

Hey @david-fiaty-cko, my apologies, I found there was an override in my theme, preventing the embedded url from showing outside the checkout. It works without that override. However I would still point out that for performance purposes my PR should still be considered so that the script is not render blocking. including script tags in a template is not in keeping with magento best practices.

from checkout-magento2-plugin.

david-fiaty-cko avatar david-fiaty-cko commented on July 17, 2024

@joe-vortex, thanks for your message. We are working on a new version of the module that will consider your observations.

The current release is stable. It's preferable not to add changes not addressing an issue that will require additional testing and maybe impact other merchants. Thank you.

from checkout-magento2-plugin.

joe-vortex avatar joe-vortex commented on July 17, 2024

sure, thanks for taking the time to consider my suggestion.

from checkout-magento2-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.