Giter Club home page Giter Club logo

Comments (10)

charlielee avatar charlielee commented on July 17, 2024 1

I am happy for this to be closed

from boats-animator.

rioforce avatar rioforce commented on July 17, 2024

I just edited the post, btw

from boats-animator.

charlielee avatar charlielee commented on July 17, 2024

It's funny you should mention themes, I was briefly thinking about them myself the other day! I think they would certainly be a worth while feature to eventually have in BA. Obviously there quite a few bigger things to implement first but I will definitely add themes to the future features list I have. 😄

from boats-animator.

le717 avatar le717 commented on July 17, 2024

I also have some notes (mainly more lower-level code stuff but also UX/UI) on themes I'll eventually post.

from boats-animator.

charlielee avatar charlielee commented on July 17, 2024

Obvious theming is still a way off but it would be great if there was eventually a tablet mode theme. This would increase the size of some of the UI elements and remove the hover effects used in the CSS.

from boats-animator.

charlielee avatar charlielee commented on July 17, 2024

Another comment:
Using a CSS preprocessor like LESS or SASS seems a good way of eventually implementing themes since they give us the ability to use variables for things such as colours. LESS appears to be easier to implement and is JavaScript based.

A native CSS solution for variables also appears to be in the works although this has only be added to the upcoming Chrome 49 so I suppose it will take a while to trickle down to NW.js

from boats-animator.

le717 avatar le717 commented on July 17, 2024

I personally use Sass (and was eventually going to suggest BA use it as it'd actually make development nicer), but as Sass is Ruby-based (C if you use libsass), LESS might be a better choice. I need to learn LESS anyway. For performance, we could compile BA's LESS (because yes, we would switch to it internally) to CSS and use that in release builds and invoke LESS only when a non-core theme is used.

IDK, NW.js v0.13.0-beta4 has Chrome 48. 48 moved to the beta channel in early December and each version moves up in the channel roughly every six weeks... There might be a shot at NW.js getting Chrome 49, but a preprocessor would be a better idea.

from boats-animator.

charlielee avatar charlielee commented on July 17, 2024

I've been using Sass a lot at work. It would be lovely to have it in this project. Also node sass exists

https://github.com/sass/node-sass/

from boats-animator.

le717 avatar le717 commented on July 17, 2024

Actually, while Sass is indeed nice, you may not need to use it for themes. Have you heard of CSS custom properties? https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

They are really nice. Like, for real, and great for themes. Just override the property values with new color values and everything changes. I've got a demo project that uses them for theming if you want to take a look as well as a couple other sites that do the same.

from boats-animator.

le717 avatar le717 commented on July 17, 2024

I'm going to recommend closing this issue. Themes have literally never come up and, considering how much light affects animation, it's doubtful it will ever be needed. It's not like someone would use a light theme to film like they would in coding. A well-designed app color scheme is really all you need (which Boats mostly already has).

from boats-animator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.