Markdown image size is incorrect about react-native-simple-markdown HOT 14 CLOSED

Hi! Can you show me your code plz? I have an idea about what could be the problem.

from react-native-simple-markdown.

var str = "![](https://d1rnv32spgedkm.cloudfront.net/image%2Fde3%2Fa6b%2F650%2Fe26cf40afb5ded4.jpg)

return (<Markdown>
  { str }
</Markdown>)

And I think that's basically it.

from react-native-simple-markdown.

You're displaying content but it doesn't correspond to the variable str which contains the URL. Maybe that's where your error come from.

from react-native-simple-markdown.

It's a typo. I just edited it. Sorry..

from react-native-simple-markdown.

OK I got it: the issue is on my side. I have to set the resizeMode prop of the Image element, and I think it will between cover or contain.
The problem is the margin though. With cover you have no margin, but the image is cropped:

With the contain prop you have this huge margin depending on the size of the picture:

What do you think about it?

from react-native-simple-markdown.

I think it's all fine depends on the use case. However do you think maybe pass something like image style into <Markdown > is a good idea?

from react-native-simple-markdown.

Well it wouldn't work though because resizeMode is handle by <Image /> props, not by its style. And there's no style property for this use case in RN I think.

from react-native-simple-markdown.

I was kind of thinking maybe something like {resizeMode==='contain' && <Image resizeMode={'contain'} /> || <Image resizeMode={'cover'} />}.

from react-native-simple-markdown.

Oh ok! Sorry I didn't get you. For the time being, it seems to be a good idea: I just implemented it, you can update with a npm i react-native-simple-markdown. Tell me if it's ok!

from react-native-simple-markdown.

For those images whose height is greater than width the output seems to be weird..

from react-native-simple-markdown.

Your image seems to be the same here:

and here:

Where's the differences plz?

from react-native-simple-markdown.

I think normally markdown images wouldn't have anything to do with alignments but I guess I can do something from my side anyways. :) thanks!

from react-native-simple-markdown.

Your welcome!

from react-native-simple-markdown.

Closing issue #8

from react-native-simple-markdown.