Giter Club home page Giter Club logo

Comments (9)

CharlesMangwa avatar CharlesMangwa commented on June 28, 2024

Hi @mtt87! I just tried to reproduce your bug with 2 images, but I couldn't, here's the output:
capture d ecran 2016-10-29 a 10 19 47

Did you apply another style that could be interfering with it?

from react-native-simple-markdown.

mtt87 avatar mtt87 commented on June 28, 2024

These are the styles I'm applying:

const stylesMarkdown = {
  image: {
    width: Dimensions.get('window').width - 30,
    height: 300,
    resizeMode: 'contain',
    marginTop: 15,
    marginBottom: 15,
    flex: 1,
  },
  paragraph: {
    fontFamily: 'Roboto',
    // fontSize: 14,
    // lineHeight: 19,
  },
};

from react-native-simple-markdown.

CharlesMangwa avatar CharlesMangwa commented on June 28, 2024

One of the reasons could be resizeMode. For the time being, you have to set it as a normal rule like image or paragraph. But by default it's set at contain so: you don't need to define it there.
Also: did you try to remove the flex: 1? Considering that you've already set a width & height, this is maybe not useful. Tell me if it helps!

from react-native-simple-markdown.

mtt87 avatar mtt87 commented on June 28, 2024

I'm gonna try this tomorrow, sorry for the delay 😄 I was building other features

from react-native-simple-markdown.

mtt87 avatar mtt87 commented on June 28, 2024

No way, still it happens (only with lineHeight)
As reference this is the full code of the page

import React from 'react';
import {
  StyleSheet,
  Text,
  ScrollView,
  Dimensions,
} from 'react-native';
import Markdown from 'react-native-simple-markdown';
import moment from 'moment';

const styles = StyleSheet.create({
  container: {
    flex: 1,
    padding: 15,
    marginTop: 65,
    marginBottom: 55,
    flexDirection: 'column',
  },
  title: {
    textAlign: 'center',
    fontSize: 22,
    fontWeight: 'bold',
    marginBottom: 15,
    color: '#333',
  },
});

const stylesMarkdown = {
  image: {
    width: Dimensions.get('window').width - 30,
    height: 300,
    marginTop: 15,
    marginBottom: 15,
  },
  paragraph: {
    fontFamily: 'Roboto',
    fontSize: 15,
    // lineHeight: 19,
  },
};

const SingleEvent = ({ markdown, eventData }) =>
  <ScrollView style={styles.container}>
    <Text style={styles.title}>
      {eventData.title}
    </Text>
    <Text style={{ textAlign: 'center', fontSize: 16, color: '#555' }}>
      {moment(eventData.event_start, 'YYYY-MM-DD HH:mm:ss').format('DD MMM HH:mm')}
    </Text>
    <Text style={{ textAlign: 'center', fontSize: 16, marginBottom: 20, color: '#555' }}>
      {eventData.venue_name}
    </Text>
    <Markdown styles={stylesMarkdown}>
      {markdown}
    </Markdown>
  </ScrollView>;

SingleEvent.propTypes = {
  markdown: React.PropTypes.string,
  eventData: React.PropTypes.shape({
    title: React.PropTypes.string.isRequired,
    event_start: React.PropTypes.string.isRequired,
    venue_name: React.PropTypes.string.isRequired,
  }),
};

export default SingleEvent;

from react-native-simple-markdown.

CharlesMangwa avatar CharlesMangwa commented on June 28, 2024

Hi @mtt87! Sorry for the delay! Do you still have the same problem?

from react-native-simple-markdown.

mtt87 avatar mtt87 commented on June 28, 2024

@CharlesMangwa Yes in the end I've submitted the app without that change.
Can you spot something strange in my code? 😄

from react-native-simple-markdown.

CharlesMangwa avatar CharlesMangwa commented on June 28, 2024

@mtt87 I didn't spot anything that could cause this issue 😕… I'll try again to reproduce it and fix it asap!

from react-native-simple-markdown.

CharlesMangwa avatar CharlesMangwa commented on June 28, 2024

Closing issue #12

from react-native-simple-markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.