Test failures on Windows about python-libarchive-c HOT 6 OPEN

@Changaco I cannot understand what this code does, why and how. Sorry for my crass ignorance, but I need your help.
https://github.com/Changaco/python-libarchive-c/blob/master/libarchive/write.py#L56

here: https://github.com/Changaco/python-libarchive-c/blob/master/libarchive/write.py#L61
Why are you trying to read the files to add to the archive as if they were archives themselves?

from python-libarchive-c.

Why are you trying to read the files to add to the archive as if they were archives themselves?

Because that's the correct way to do it. libarchive handles walking the file system and filling the entry struct, the python code reads the actual content of the files and ties everything together.

from python-libarchive-c.

FWIW, I do not care for writing archives since I use libarchive only to extract things, but I am still not sure why you would use a combo of opening and reading the file in Python and using the directory traversal of libarchive. If read things correctly, libarchive can do both traversal and file reading?

from python-libarchive-c.

@Changaco I still think that there is something that is likely not to work at all on posix for special files here: https://github.com/Changaco/python-libarchive-c/blob/master/libarchive/write.py#L68
Opening a FIFO or character/device file like this usually has funny consequences such has a hanging.
libarchive knows how to handle these alright afaik, so reading in python is likely not covering all the cases. Doing a test with a temp os.mkfifo is likely to break IMHO

from python-libarchive-c.

@Changaco any idea on this?

from python-libarchive-c.

Looks like I forgot to answer here.

If read things correctly, libarchive can do both traversal and file reading?

Does it? I don't remember seeing a function to do the actual file reading in libarchive.

from python-libarchive-c.