Giter Club home page Giter Club logo

Comments (3)

lachesis avatar lachesis commented on June 22, 2024 1

Reporting back as promised. I've been running with this simple patch for over a month now, with no major issues. This probably breaks macro support on older Asterisk. I would guess the correct answer is to add some new entries to the pbx_impl then do the right autotools magic to make it select those for 21+.

from chan-sccp.

lachesis avatar lachesis commented on June 22, 2024

Confirmed, doesn't build for me on Asterisk 21 either. I guess the right answer is to remove all of the macro related code?

from chan-sccp.

lachesis avatar lachesis commented on June 22, 2024

It built for me with this patch:

diff --git a/src/pbx_impl/ast116/ast116.c b/src/pbx_impl/ast116/ast116.c
index c162e755..f6364dca 100644
--- a/src/pbx_impl/ast116/ast116.c
+++ b/src/pbx_impl/ast116/ast116.c
@@ -3065,10 +3065,6 @@ DECLARE_PBX_CHANNEL_STRGET(name)
     DECLARE_PBX_CHANNEL_STRGET(linkedid)
     DECLARE_PBX_CHANNEL_STRGET(context)
     DECLARE_PBX_CHANNEL_STRSET(context)
-    DECLARE_PBX_CHANNEL_STRGET(macroexten)
-    DECLARE_PBX_CHANNEL_STRSET(macroexten)
-    DECLARE_PBX_CHANNEL_STRGET(macrocontext)
-    DECLARE_PBX_CHANNEL_STRSET(macrocontext)
     DECLARE_PBX_CHANNEL_STRGET(call_forward)
     DECLARE_PBX_CHANNEL_STRSET(call_forward)

@@ -3536,10 +3532,6 @@ const PbxInterface iPbx = {
        setChannelExten: sccp_astwrap_set_channel_exten,
        getChannelContext: sccp_astwrap_get_channel_context,
        setChannelContext: sccp_astwrap_set_channel_context,
-       getChannelMacroExten: sccp_astwrap_get_channel_macroexten,
-       setChannelMacroExten: sccp_astwrap_set_channel_macroexten,
-       getChannelMacroContext: sccp_astwrap_get_channel_macrocontext,
-       setChannelMacroContext: sccp_astwrap_set_channel_macrocontext,
        getChannelCallForward: sccp_astwrap_get_channel_call_forward,
        setChannelCallForward: sccp_astwrap_set_channel_call_forward,

@@ -3687,10 +3679,6 @@ const PbxInterface iPbx = {
        .setChannelExten = sccp_astwrap_set_channel_exten,
        .getChannelContext = sccp_astwrap_get_channel_context,
        .setChannelContext = sccp_astwrap_set_channel_context,
-       .getChannelMacroExten = sccp_astwrap_get_channel_macroexten,
-       .setChannelMacroExten = sccp_astwrap_set_channel_macroexten,
-       .getChannelMacroContext = sccp_astwrap_get_channel_macrocontext,
-       .setChannelMacroContext = sccp_astwrap_set_channel_macrocontext,
        .getChannelCallForward = sccp_astwrap_get_channel_call_forward,
        .setChannelCallForward = sccp_astwrap_set_channel_call_forward,

The module that it build loaded. I have not tested further yet. Will report back once my first SCCP phone is here and I test it out later today.

from chan-sccp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.