Comments (5)
you're right, we made a mistake by including those properties
strictPropertyValues
should restrict any CSS property that has a syntax with predefined values to those values only
border
can be complex like 1px solid blue
so it shouldn't be restricted
borderStyle
however can still be restricted
from panda.
Ah, ok, great. Thanks for the quick fix!
from panda.
@astahmer As one potential follow-up, FYI I just noticed that borderStyle
is not currently in StrictableProps
but has the same restricted subset of values, since it's the shorthand for the border*Style
properties that are currently in StrictableProps
. The one nuance is that it can have multiple values, e.g. border-style: none solid dotted dashed;
.
from panda.
adding that to the list would prevent such use-case none solid dotted dashed
so I guess it's better not to ?
from panda.
Ah, ok. I guess I was thinking the TS type could be something like this:
BorderStyle | `${BorderStyle} ${BorderStyle}` | `${BorderStyle} ${BorderStyle} ${BorderStyle}` | `${BorderStyle} ${BorderStyle} ${BorderStyle} ${BorderStyle}`
But maybe that's not workable for some reason? It does require a relatively new TS version to support template literal types.
from panda.
Related Issues (20)
- cva not extracting css in 0.33.0 HOT 1
- CVA and SVA not pre-generating CSS HOT 1
- backgroundImage doesn't work with template string as value HOT 1
- Pattern styles not compiled in monorepo
- Pattern styles not compiled in monorepo HOT 4
- Panda config polyfill & preflight options bug HOT 2
- Styles not generated on windows
- Color opacity modifier syntax (blue.300/70) in token references doesn't work with conditions HOT 1
- Recipe invalid when I change the name of the component HOT 1
- Config Recipe are not extracted properly using `raw` function HOT 2
- Using color opacity modifier syntax in semantic tokens with conditions will throw an error in validation
- Duplicated classes in extended components HOT 2
- Allow multi themes on pandacss/studio
- Issue with tokens colors in panda studio HOT 1
- `token` method returns "CSS Variable" for semanticColors
- Token function can't use color opacity modifier HOT 1
- CSS variables are not valid values for `StrictableProps` when `strictPropertyValues` is enabled HOT 1
- Slot selector doesn't work if hashing is enabled HOT 1
- Type errors on greenfield project w/ Panda
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from panda.