Giter Club home page Giter Club logo

Comments (5)

astahmer avatar astahmer commented on June 4, 2024 1

you're right, we made a mistake by including those properties
strictPropertyValues should restrict any CSS property that has a syntax with predefined values to those values only

border can be complex like 1px solid blue so it shouldn't be restricted
borderStyle however can still be restricted

#2336

from panda.

etlovett avatar etlovett commented on June 4, 2024

Ah, ok, great. Thanks for the quick fix!

from panda.

etlovett avatar etlovett commented on June 4, 2024

@astahmer As one potential follow-up, FYI I just noticed that borderStyle is not currently in StrictableProps but has the same restricted subset of values, since it's the shorthand for the border*Style properties that are currently in StrictableProps. The one nuance is that it can have multiple values, e.g. border-style: none solid dotted dashed;.

from panda.

astahmer avatar astahmer commented on June 4, 2024

adding that to the list would prevent such use-case none solid dotted dashed so I guess it's better not to ?

from panda.

etlovett avatar etlovett commented on June 4, 2024

Ah, ok. I guess I was thinking the TS type could be something like this:

BorderStyle | `${BorderStyle} ${BorderStyle}` | `${BorderStyle} ${BorderStyle} ${BorderStyle}` | `${BorderStyle} ${BorderStyle} ${BorderStyle} ${BorderStyle}`

But maybe that's not workable for some reason? It does require a relatively new TS version to support template literal types.

from panda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.