Comments (2)
Thanks for digging into the issue and suggesting a fix.
I don't recommend importing the svg
file in the theme file. Kindly refactor it to separate the theme from the custom component code.
You can also keep the patch for now. In the v3 version, we'll consider it.
from chakra-ui.
Hey @segunadebayo appreciate the response!
We don't have svg
imports directly in our theme file. Our structure is roughly equivalent to the following:
// ChakraThemeProvider.tsx
import {
AlertStyles,
CheckboxStyles,
// ...etc
} from 'our-ui-library';
const theme = extendTheme({
components: {
Alert: AlertStyles,
Checkbox: CheckboxStyles,
// ...etc
}
})
where our-ui-library
is an (internal) npm package with an index file that looks like this:
// index.ts
export { Checkbox } from './src/Checkbox';
export { CheckboxStyles } from './src/Checkbox.style';
In this case Checkbox.tsx
has an .svg
import that is used with the file. Our CLI is set to generate types from the ChakraThemeProvider.tsx
file, but my guess is that esbuild is following the imports from the entry file and choking because it ends up trying to build the Checkbox.tsx
file with the .svg
imports.
Unfortunately its a bit difficult to change our file structure due to our-ui-library
being a separate npm package. If I'm understanding what you're saying, we'd need to rethink our file/bundling structure in this package to ensure esbuild
won't end up trying to build files in our internal package that have non-JS imports correct?
from chakra-ui.
Related Issues (20)
- Change `fireEvent` to `user` in the `focus-look` component test HOT 1
- Add imageDidLoad callback to Image props?
- Change `fireEvent` to `user` in the `editable` component test HOT 1
- `iconMapping` prop for Alerts
- `interactive` and `active` props for `Card`
- Remove `await` and change `fireEvent` to `user` in the `editable` component test HOT 1
- Using colors without specifying the the shade does not show the default color HOT 1
- Provide a anchor element as prop so that popover can be decoupled from anchor element
- Framer-motion 11.2.0 breaks Popover `initialFocusRef` functionality HOT 4
- Wrong position of Tooltip with child Icon element HOT 3
- Icon component missing variant prop
- Popover usePortal prop not supported as described by documentation
- Highligh not marking the texts correctly HOT 1
- Collapse Docs are missing in v2
- Links in changelog to release notes is broken HOT 1
- Fixed: number input test HOT 1
- Custom Colors Not Suggested HOT 4
- DrawerTrigger is not exported in Chakra-UI v3 (React) HOT 2
- Date input calendar does not toggle properly HOT 1
- [Next] Chakra V3 Feedback HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chakra-ui.